feat(models): add missing RevocationReason variants (RFC 5280)#58
Closed
Swaagie wants to merge 1 commit into
Closed
feat(models): add missing RevocationReason variants (RFC 5280)#58Swaagie wants to merge 1 commit into
Swaagie wants to merge 1 commit into
Conversation
Adds CaCompromise, ExpiredCert, RemoveFromCrl, and Unspecified to match the full set of reason codes accepted by the ANS API and exposed by the Go SDK. ExpiredCert and Unspecified are specifically needed to attempt recovery of registrations stuck in PENDING_VALIDATION past their expiresAt.
Contributor
Coverage Report
|
Contributor
Author
|
Closing — both EXPIRED_CERT and UNSPECIFIED are rejected by the server with a JSON mapping error (not recognized server-side). Adding these variants would give false confidence that they work. The Go SDK includes them in client-side validation but the ANS API does not accept them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds four
RevocationReasonvariants that are present in the Go SDK but missing from the Rust SDK:CaCompromise— CA was compromisedExpiredCert— certificate has expiredRemoveFromCrl— remove from CRLUnspecified— no specific reasonExpiredCertandUnspecifiedare the immediate motivation: they are needed to attempt recovery of agent registrations stuck inPENDING_VALIDATIONpast theirexpiresAt, whereCESSATION_OF_OPERATIONis rejected with 422.Test plan
cargo build— clean across full workspaceEXPIRED_CERTandUNSPECIFIEDare accepted by the API against a stuck registration