Skip to content

Show oauth login browser link during auth login#63

Closed
jbrooks2-godaddy wants to merge 1 commit into
rust-portfrom
codex/oauth-login-progress
Closed

Show oauth login browser link during auth login#63
jbrooks2-godaddy wants to merge 1 commit into
rust-portfrom
codex/oauth-login-progress

Conversation

@jbrooks2-godaddy

Copy link
Copy Markdown
Collaborator

Small change to give a bit more output during the auth flow. Two goals:

  1. Make it clear to the user (or driving agent) what is happening
  2. Show the OAuth url in case the browser does not automatically open

Output during gddy auth login now looks like:

> gddy auth login --env prod
Opening browser for authentication…
If the browser does not open, visit:
  https://api.godaddy.com/v2/oauth2/authorize?response_type=code&client_id=bc87f347-af82-4892-833f-818f54a0e79e&redirect_uri=http%3A%2F%2Flocalhost%3A7443%2Fcallback&scope=apps.app-registry%3Aread+apps.app-registry%3Awrite&state=k6T6WR7ur8bjikaOCO2alw&code_challenge=GkYAMlefo88FiBIj7-xsCoW46JEYcNRaUOfHDVIho4M&code_challenge_method=S256

Found that the PKCE auth provider in cli-engine already provides this output as info tracing, so just exposed that - open to better ways to show this kind of detail.

@jbrooks2-godaddy

Copy link
Copy Markdown
Collaborator Author

Closing in favor of godaddy/cli-engine#24 approach, will get this functionality in next cli-engine bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants