Improve Windows VM detection for VDI environments#164
Merged
Conversation
Expand VM detection to catch VDI environments (CyberArk, Citrix on Hyper-V) that don't present standard VM manufacturer strings: - Add Hyper-V guest integration services registry key check (SOFTWARE\Microsoft\Virtual Machine\Guest\Parameters). Present on all Hyper-V guests but NOT on physical VBS hosts. - Add disk device name check (Services\Disk\Enum\0) for VM-specific disk controller strings. - Expand registry checks to include BIOSVersion, SystemVersion, BaseBoardManufacturer, and BaseBoardProduct. - Add VM string signals: cyberark, seabios, proxmox, openstack, oracle vm. - New detection path: Microsoft Hv CPUID + guest integration services = Hyper-V VDI (catches non-standard manufacturers). Expose VmDiagnostics struct and collect_vm_diagnostics() public function so consuming applications can log raw system signals for debugging unrecognized VM environments. Refactor internal detection into collect_vm_diagnostics_windows() which collects all data and decides in one pass, eliminating the old VmDetection/detect_vm() indirection.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VmDiagnosticsstruct andcollect_vm_diagnostics()public API for consumer-side diagnostic loggingTest plan
hyperv_guest_parameters_exist()returns true