Fix windows crate 0.58 API mismatch in VM detection#166
Merged
Conversation
The windows crate 0.58 takes u32 for the uloptions parameter, not Option<u32> (which is the 0.62 API). This broke the CI build.
jgowdy-godaddy
force-pushed
the
feat/improve-windows-vm-detection
branch
from
05b4773 to
7080733
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RegOpenKeyExWuloptions parameter:Some(0)→0forwindowscrate 0.58 compatibilityThe prior commit (30990e0) was included in a squash merge that created a different commit hash on main, so it shows as new here, but the API fix in 05b4773 is the only net-new change vs what's on main.
Test plan
cargo clippy --workspace --all-targets -- -D warningspassescargo test --workspace --all-targetspassesSome(0)type mismatch)