Skip to content

Commit 939cd05

Browse files
authored
Merge pull request #47 from godon-dev/fix/metadata-sql-quotes
fix: wrap metadata_json in SQL quotes for target and credential inserts
2 parents d254a7c + cd21eec commit 939cd05

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

controller/database.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ def fetch_breeders_list(self):
252252
def insert_credential(self, credential_id, name, credential_type, description, windmill_variable, store_type='windmill_variable', metadata=None):
253253
"""Insert credential catalog entry"""
254254
db_config = self._get_db_config()
255-
metadata_json = json.dumps(metadata) if metadata else 'NULL'
255+
metadata_json = "'" + json.dumps(metadata).replace("'", "''") + "'" if metadata else 'NULL'
256256
description_escaped = "'" + description.replace("'", "''") + "'" if description else 'NULL'
257257

258258
query = f"""
@@ -336,7 +336,7 @@ def insert_target(self, target_id, name, target_type, spec, metadata=None):
336336
"""Insert target catalog entry"""
337337
db_config = self._get_db_config()
338338
spec_json = json.dumps(spec) if isinstance(spec, dict) else spec
339-
metadata_json = json.dumps(metadata) if metadata else 'NULL'
339+
metadata_json = "'" + json.dumps(metadata).replace("'", "''") + "'" if metadata else 'NULL'
340340

341341
query = f"""
342342
INSERT INTO {self.targets_table_name}

0 commit comments

Comments
 (0)