feat: add target catalog with CRUD scripts and targetRefs resolution#43
Merged
feat: add target catalog with CRUD scripts and targetRefs resolution#43
Conversation
Targets are now first-class catalog entries. Breeder configs reference targets by ID or name via effectuation.targetRefs instead of inline definitions. The controller resolves refs to inline targets once at breeder creation time. - targets table in metadata DB (name, type, address, username, credential_id) - CRUD Windmill scripts: target_create, target_get, targets_get, target_delete - config.py: require targetRefs, remove inline target validation - breeder_service._resolve_target_refs: fetch targets from catalog - Unit tests for target CRUD (22 tests) and updated config validation tests
The database.py module imports from f.controller.shared.otel_logging which wasn't mocked in CI. Also added target CRUD modules to the pre-populated module list and updated breeder test config to use targetRefs instead of inline targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets are now first-class catalog entries. Breeder configs reference targets by ID or name via effectuation.targetRefs instead of inline definitions. The controller resolves refs to inline targets once at breeder creation time.