Skip to content

fix: wrap metadata_json in SQL quotes for target and credential inserts #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cherusk merged 1 commit into from
Apr 16, 2026
Merged

fix: wrap metadata_json in SQL quotes for target and credential inserts #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions controller/database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ def fetch_breeders_list(self):
def insert_credential(self, credential_id, name, credential_type, description, windmill_variable, store_type='windmill_variable', metadata=None):
"""Insert credential catalog entry"""
db_config = self._get_db_config()
metadata_json = json.dumps(metadata) if metadata else 'NULL'
metadata_json = "'" + json.dumps(metadata).replace("'", "''") + "'" if metadata else 'NULL'
description_escaped = "'" + description.replace("'", "''") + "'" if description else 'NULL'

query = f"""
Expand Down Expand Up @@ -336,7 +336,7 @@ def insert_target(self, target_id, name, target_type, spec, metadata=None):
"""Insert target catalog entry"""
db_config = self._get_db_config()
spec_json = json.dumps(spec) if isinstance(spec, dict) else spec
metadata_json = json.dumps(metadata) if metadata else 'NULL'
metadata_json = "'" + json.dumps(metadata).replace("'", "''") + "'" if metadata else 'NULL'

query = f"""
INSERT INTO {self.targets_table_name}
Expand Down
Loading