Rust-side Variant marshalling#1600
Draft
Bromeon wants to merge 6 commits into
Draft
Conversation
Bromeon
added
c: core
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1600 |
Bromeon
force-pushed
the
perf/variant-rust-marshal
branch
5 times, most recently
from
2c3233f to
3a3fc71
Compare
Generated from `has_destructor` in `extension_api.json`. Used internally to detect POD types eligible for rust-side variant marshalling.
…fast `Extend` `Extend` pre-allocates via `size_hint` and writes variants directly into slots. Panics on iterator under-yield (size_hint contract violation).
POD builtins bypass FFI via inline-memory marshalling. Dispatch is internal: `rust_to_variant`/`rust_from_variant` select the path. `RustMarshal: GodotType<Ffi = Self>` documents the contract -- the type IS its own FFI carrier.
`Variant::default()` returns `mem::zeroed()` (NIL is type-tag 0 with zeroed data). `Variant::clone()` performs a bytewise `ptr::read` for POD types; non-POD falls through to `variant_new_copy` FFI. `Variant::drop()` skips `variant_destroy` for POD types, as it is a no-op for them in Godot. All three fast paths are gated on `#[cfg(not(feature = "variant-ffi-marshal"))]` so A/B benchmarks keep working.
Tests roundtrip via public API and direct `RustVariant` view for all `RustMarshal` types. Benches: `Array::extend` size-hint fast path, packed-to-typed conversion.
Bromeon
force-pushed
the
perf/variant-rust-marshal
branch
from
3a3fc71 to
c46ca24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
VariantholdingCopybuiltin types (or rather those that don't need an FFI constructor/destructor), we can emulate Godot'sVariantlayout directly in Rust. This saves a large number of FFI calls for justVariantconversions and has the potential to speed up operations across the board.