Skip to content

Proposal: Update minimum Emacs version to 29.1 #205

Description

@charjr

Arguments For

defvar-keymap

I've got a local branch ready to go that simplifies our keymap with the defvar-keymap macro, I wanted to push it then realised it was introduced in 29.1.

font-lock-function-call-face and font-lock-variable-use-face

These faces were introduced in 29.1 they distinguish between usage and declarations, i.e.

var foo:           # variable-name-face
    get:
        get_foo()  # function-call-face
 

func get_foo():    # function-name-face
    return foo     # variable-use-face

I do not have this ready-to-go but I would be happy to implement this. I prefer to emphasise function names like they're section headings, but I can't in GDScript because it gets obnoxious when every single function call is emphasised as well.

Probably a Bunch of Other Things I Don't Know About Yet 🤷

🔍

Arguments Against

We lose compatibility with older Emacsen.

Arguments Against the Arguments Against

  • Emacs 29.1 was released July 2023, nearly three years ago.
  • Debian's latest stable version (famous for its often outdated packages) offers 30.1
    • Debian's previous stable version offers 30.1 through backports.
    • If Debian has 29.1 I think it's safe for us to do so as well.
  • Users on versions lower than 29.1 can just use the old version of gdscript-mode perfectly fine anyway.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions