Default keybindings override reserved keys

[schwopo]

The default keybindings C-c i C-c r C-c n define C-c followed by a letter. These bindings are safe keys reserved for user keybindings and should not be used for mode bindings.

See: https://www.gnu.org/software/emacs/manual/html_node/emacs/Key-Bindings.html

"The reserved key sequences are those consisting of C-c followed by a letter (either upper or lower case), and function keys F5 through F9 without modifiers"

[charjr]

[C-c is] reserved for user keybindings and should not be used for mode bindings.

I completely agree. The Emacs manual explicitly states that modes should not use C-c.

Unfortunately, this part of the manual is actively ignored in just about every major mode ever created, including those held in the highest regard (Just take a look at c-mode and org-mode or any built-in mode). So users typically expect to find mode-specific keys here.

There even exists a built-in mode-specific-map for keys bound to C-c which seems to me, a living contradiction of the manual, built right into the core bindings.el.

EDIT: Today I learned something

Back on Topic

I've had an idea on the backburner for a while, which as a side-effect, may solve this issue by removing the need for most of our C-c bindings. Please let me know what you think.

I'd like to replace the gdscript-hydra with Transient the library behind the contextual menus found in everyone's favourite: Magit. I would also wrap other long keychords into easy to follow transient menus so that users don't have to memorise long and mode-specific keychords.

• All Godot launch options would be under a transient called with M-x godot.

• All GDScript formatting, debugging and docs could be found with M-x gdscript.

(It also has the bonus of relying on a built-in library vs an external one which vanilla Emacs users like myself don't have by default)

cc @NathanLovato @jcs090218 approval, rejection, suggestions etc.

[NathanLovato]

Actually our C-c keymaps, I think originally I just modeled after the Python module package. Notably because personally, I was a 100% evil mode + which key user and did not use those myself.

About the package to use I will just say: relying on native features/libs when possible sounds good. but I'll leave it to people actively using Emacs to decide.

[charjr]

Actually our C-c keymaps, I think originally I just modeled after the Python module package. Notably because personally, I was a 100% evil mode + which key user and did not use those myself.

I unbind the C-c keymap so I've never used it either, but the reserved keys f5 through to f9: I must say I like those, hitting f5 and having it work just like Godot is how I want it.

But a custom variable like dired-x-hands-off-my-keys might solve this issue. Basically something like this:

gdscript-hands-off-my-keys

Its value is nil

Non-nil means don’t remap user-reserved keys `C-c` or the function keys `f5` through to `f9`.

A default value of nil would preserve BC but still let user's unbind it if they prefer.

About the package to use I will just say: relying on native features/libs when possible sounds good. but I'll leave it to people actively using Emacs to decide.

👍

I'll see what I can do. My original plan was to keep quiet unless I made a replacement that I considered a direct upgrade.

[schwopo]

I completely agree. The Emacs manual explicitly states that modes should not use C-c.

Actually only C-c followed by a non-modified letter is reserved. With modifiers, its the intended keybinding for major modes. Generally C-x followed by anything is globally applicable keys, for example window management. C-c followed by C-anything is for the major mode. C-c followed by unmodified keys is reserved.

For example:
C-x C-c closes emacs
C-c C-c comment-region in c-mode
C-c c is user defined, bury-buffer for me

Thank you for looking into this issue

[charjr]

Actually only C-c followed by a non-modified letter is reserved. With modifiers, its the intended keybinding for major modes.

Ah! I can't believe I misunderstood that part of the manual all these years. 😓 Thank you for enlightening me. 🙏

For example: C-x C-c closes emacs C-c C-c comment-region in c-mode C-c c is user defined, bury-buffer for me

Right, so if I understand (now) the problem is:

• C-c i gdscript-completion-insert-file-path-at-point
  • We can replace with C-c C-i
• C-c n gdscript-debug-hydra
  • We can replace with C-c C-n

I've done this in #208

• C-c r gdscript-hydra-show

  • I'm looking to replace this one... I've made a prototype locally (and enjoying using it on my own project right now 😊) but it's not a complete replacement yet.

• f5 f6 f7 and f9

  • Simplest solution would be C-c f5 and so on, but I like that they're bound to the same key as Godot and I suspect anyone who doesn't rebind function keys probably feels the same. I think the best compromise here is the gdscript-hands-off-my-keys approach I mentioned above.