Merge pull request #1510 from dsnopek/memnew-better-crash-message

dsnopek · web-flow · commit 8012716ee3cd · 2024-07-15T12:15:53.000-05:00
Remind developers about `memnew()` in crash message when missing binding callbacks
diff --git a/src/classes/wrapped.cpp b/src/classes/wrapped.cpp
@@ -84,8 +84,7 @@ Wrapped::Wrapped(const StringName p_godot_class) {
 		godot::internal::gdextension_interface_object_set_instance_binding(_owner, godot::internal::token, this, _constructing_class_binding_callbacks);
 		_constructing_class_binding_callbacks = nullptr;
 	} else {
-		ERR_PRINT("BUG: create a Godot Object without binding callbacks.");
-		CRASH_NOW_MSG("BUG: create a Godot Object without binding callbacks.");
+		CRASH_NOW_MSG("BUG: Godot Object created without binding callbacks. Did you forget to use memnew()?");
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -84,8 +84,7 @@ Wrapped::Wrapped(const StringName p_godot_class) {`
`84`	`84`	`godot::internal::gdextension_interface_object_set_instance_binding(_owner, godot::internal::token, this, _constructing_class_binding_callbacks);`
`85`	`85`	`_constructing_class_binding_callbacks = nullptr;`
`86`	`86`	`} else {`
`87`		`- ERR_PRINT("BUG: create a Godot Object without binding callbacks.");`
`88`		`- CRASH_NOW_MSG("BUG: create a Godot Object without binding callbacks.");`
	`87`	`+ CRASH_NOW_MSG("BUG: Godot Object created without binding callbacks. Did you forget to use memnew()?");`
`89`	`88`	`}`
`90`	`89`	`}`
`91`	`90`