[SCons] Add warnings build options#1007
Draft
Faless wants to merge 2 commits intogodotengine:masterfrom
Draft
Conversation
Faless
added
bug
Contributor
Author
|
scons part of #999 , thanks a lot to @asmaloney for doing the initial work on fixing warnings. |
Contributor
|
Excellent! I'm CI-testing my cmake changes right now too , so I will wait for this to be merged. |
Contributor
|
This is odd because I'm not getting any warnings on the files you changed... I've checked my option conversion a couple of times and it looks OK (granted my ☕ level is low). I wonder if I'm missing something... |
Contributor
Author
|
@asmaloney the error with the scons CI seems to come from building the test library, and the cmake counterpart seems to always use the I wonder if we should do the same with the scons builds. |
Faless
force-pushed
the
ext/warnings
branch
2 times, most recently
from
6acd2ad to
36c43a5
Compare
Faless
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable scons "warnings=extra" and "werror=yes" in CI.
Fix few spotted warnings.
Draft status:
duplicated-branchesCI gcc error (cannot reproduce locally with gcc 10) when building test