Skip to content

Don't automatically treat numeric values as ObjectIDs#1957

Merged
dsnopek merged 1 commit into
godotengine:masterfrom
BenLubar:ref-non-object
Apr 21, 2026
Merged

Don't automatically treat numeric values as ObjectIDs#1957
dsnopek merged 1 commit into
godotengine:masterfrom
BenLubar:ref-non-object

Conversation

@BenLubar

Copy link
Copy Markdown
Contributor

This fixes a regression where

Variant x = 1;
Ref<RefCounted> y = x;

would print a warning rather than just setting y to null.

@BenLubar BenLubar requested a review from a team as a code owner March 24, 2026 18:34

@dsnopek dsnopek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This makes sense to me

@dsnopek dsnopek added the bug This has been identified as a bug label Mar 24, 2026
@dsnopek dsnopek added this to the 10.x milestone Mar 24, 2026
@dsnopek dsnopek merged commit a7b6c01 into godotengine:master Apr 21, 2026
19 checks passed
@BenLubar BenLubar deleted the ref-non-object branch May 19, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This has been identified as a bug cherrypick:4.5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants