Fix bad links in Exporting for web#10718
Merged
Merged
Conversation
tetrapod00
added
bug
area:manual
tetrapod00
commented
Feb 26, 2025
|
|
||
| **Hosts that don't provide on-the-fly compression:** itch.io, GitLab Pages | ||
| (`supports manual gzip precompression <https://webd97.de/post/gitlab-pages-compression/>`__) | ||
| (`supports manual gzip precompression <https://web.archive.org/web/20231004074358/https://webd97.de/post/gitlab-pages-compression/>`__) |
Contributor
Author
There was a problem hiding this comment.
Alternate:
Suggested change
| (`supports manual gzip precompression <https://web.archive.org/web/20231004074358/https://webd97.de/post/gitlab-pages-compression/>`__) |
The original PR adding lychee (#10680) suggested that archived links would be one option. However, in this case I think we could remove the link entirely
Contributor
There was a problem hiding this comment.
We could also link gitlab doc directly: https://docs.gitlab.com/user/project/pages/introduction/#serving-compressed-assets
Contributor
Author
There was a problem hiding this comment.
I'm not at all familiar with the subject matter but that does look like a reasonable substitute to me
Contributor
There was a problem hiding this comment.
Not that familiar with it either. Hopefully, someone who knows will check this.
tetrapod00
force-pushed
the
fix-web-export-links
branch
from
4418b1f to
c37e56f
Compare
skyace65
approved these changes
Feb 26, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10717 (and CI errors on all PRs).
The original blogpost (https://web.archive.org/web/20231004074358/https://webd97.de/post/gitlab-pages-compression/) links to a gitlab issue (https://gitlab.com/gitlab-org/gitlab-ce/issues/15037) which has since been resolved. Apparently there is now gitlab documentation for this feature (https://docs.gitlab.com/user/project/pages/introduction/#serving-compressed-assets), which we can link to instead. Thanks @Jackerty for the heads up