Add specific icons to admonitions#12042
Open
Cykyrios wants to merge 1 commit into
Open
Conversation
Calinou
added
enhancement
content:website
Calinou
requested changes
Jun 8, 2026
Member
There was a problem hiding this comment.
:before should be ::before instead (both work, but the former is deprecated).
Cykyrios
force-pushed
the
admonition-icons
branch
from
d2ec901 to
0731ebd
Compare
Calinou
approved these changes
Jun 9, 2026
Calinou
left a comment
Calinou
left a comment
Member
There was a problem hiding this comment.
Code and design look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #12017 adds icons to the proposed "class reference admonitions", this PR reuses the same icons and applies them to Note, Warning, Tip, and Important admonitions. All other admonitions (Danger, See also, Here be dragons, and anything else I missed) are left untouched.
This also changes the Important color from green (same as Tip) to yellow (same as Warning/Attention), for consistency in the icon color.
More images
In the following image, only the Important admonition is affected, the other two are identical to the master branch:More examples:
Depends on #12017.