First3dGame - Change randi_range to randf_range to match source, use explicit floats for min and max speed#12075
Merged
Merged
Conversation
Member
|
I have not reviewed the code. Please open a corresponding PR in the godot demo projects repository here: https://github.com/godotengine/godot-demo-projects/tree/master/3d/squash_the_creeps |
skyace65
added
needs work
The docs used randi_range instead of randf_range for the mob's random_speed which did not match the source and would cause a bug with integer division when using it to scale the animation speed.
samw-26
changed the title
samw-26
changed the title
aaronfranke
reviewed
Jun 21, 2026
aaronfranke
approved these changes
Jun 21, 2026
skyace65
removed
the
needs work
Contributor
Author
|
Thanks! |
mhilbrunner
approved these changes
Jun 29, 2026
Member
|
Thank you! And thanks for the reviews everyone. Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #9770
The docs used randi_range and integers for random_speed which does not match the source in https://github.com/godotengine/godot-demo-projects/tree/master/3d/squash_the_creeps and would cause an integer division bug when scaling the animation speed.
Additionally, min and max speed have been changed to floats for clarity. godotengine/godot-demo-projects#1329