You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's slightly confusing already by using an array match with wildcard to present a new concept. Not being obvious that it can be used for simple direct comparison.
using an array match with wildcard to present a new concept
Array patterns were introduced prior to this though.
IMHO introducing concepts with contrived examples is bad practice. What you added here is contrived. point is an array in this codeblock, so checking it with > makes no sense. Also all other branches do an actual real world check on the point while this one just makes no sense.
I meant specifically the pattern guard and when keyword being introduced using an array and wildcard. Had to see examples elsewhere to actually understand what was happening.
Though I do agree the new examples are wrong. Also couldn't use it in my specific case where I wanted a simple match comparison instead of several ifs. It seems that's just not possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's slightly confusing already by using an array match with wildcard to present a new concept. Not being obvious that it can be used for simple direct comparison.