Skip to content

Fix redirect destination validation, partial key overrides, and multiple broken redirects.csv entries#12164

Open
Ivorforce wants to merge 1 commit into
godotengine:masterfrom
Ivorforce:fix-redirects-the-like-10th
Open

Fix redirect destination validation, partial key overrides, and multiple broken redirects.csv entries#12164
Ivorforce wants to merge 1 commit into
godotengine:masterfrom
Ivorforce:fix-redirects-the-like-10th

Conversation

@Ivorforce

@Ivorforce Ivorforce commented Jul 20, 2026

Copy link
Copy Markdown
Member
  1. Due to the missing break; from the loop, later entries could override the redirect destination.
  2. The contributing.godotengine.org redirects were currently not accepted in create_redirects.py and would have been removed the next time anybody ran the script. They are supported fine though.
  3. There were several redirects broken or missing, especially from the contributing move.

Note

AI Disclaimer: I used AI to review the redirects.csv entries, to find and fix the broken ones. Others were identified using --validate — apparently never run since my changes 🙃 Personally I didn't even know the flag existed.

@Ivorforce
Ivorforce requested a review from Calinou July 20, 2026 14:08
@Ivorforce
Ivorforce requested a review from a team as a code owner July 20, 2026 14:08
@Ivorforce Ivorforce added bug content:redirect Issues and PRs involving moving content and adding a redirect rule on the backend labels Jul 20, 2026
@Ivorforce
Ivorforce force-pushed the fix-redirects-the-like-10th branch from 368baec to 7a7e3fd Compare July 20, 2026 14:16

@Calinou Calinou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for updating the redirects list 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug content:redirect Issues and PRs involving moving content and adding a redirect rule on the backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants