GDScript: Destruct remaining instances when language is finished#118191
Open
HolonProduction wants to merge 1 commit into
Open
GDScript: Destruct remaining instances when language is finished#118191HolonProduction wants to merge 1 commit into
finished#118191HolonProduction wants to merge 1 commit into
Conversation
This was referenced Apr 4, 2026
HolonProduction
force-pushed
the
gdscript/goodbye-instance
branch
from
13bdc44 to
3e14ac0
Compare
Ivorforce
approved these changes
Apr 29, 2026
Member
There was a problem hiding this comment.
Seems fine to me, matches my understanding of what destruction should guarantee.
It might be interesting to add logging if we find any that haven’t been destroyed at this time, since it might indicate a bug elsewhere.
Haven't tested; don't know the GDScriptLanguage code, but the fix looks simple and correct to me.
Not sure whether this is a good pick for 4.7. It might fix issues, but it might introduce others. So it's at least somewhat risky in my mind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #106401
When
GDScriptLanguageis destructed we now detachGDScripts from all remaining instances. This prevents crashes when other systems that get destructed later still hold references to those instances.