Try to avoid calling queue_redraw in 2D ray and shape cast set_enabled methods#118207
Open
RyanVail wants to merge 1 commit into
Open
Try to avoid calling queue_redraw in 2D ray and shape cast set_enabled methods#118207RyanVail wants to merge 1 commit into
queue_redraw in 2D ray and shape cast set_enabled methods#118207RyanVail wants to merge 1 commit into
Conversation
…thods Adds a fast path if `set_enabled` was called with the existing `enabled` value, meaning it has no effect. Only queue a redraw if collisions are being debugged, so when debugging is disabled the cost of the redraw logic can be skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit tries to avoid calling
queue_redraw, when possible, in theRayCast2D::set_enabledandShapeCast2D::set_enabledmethods so the redraw logic can be skipped.Adds a fast path if
set_enabledwas called with the existingenabledvalue, meaning it has no effect.Adds a check that only queues a redraw if collisions are being debugged because, based on what I can tell, ray casts and shape casts are only drawn when collisions are being debugged.