Autocompletion: Remove unnecessary HashMap copy#118221
Open
HolonProduction wants to merge 1 commit into
Open
Conversation
HolonProduction
force-pushed
the
completion-autoload-copy
branch
from
3bd2863 to
040ebdd
Compare
Ivorforce
approved these changes
May 5, 2026
Member
Ivorforce
left a comment
Ivorforce
left a comment
There was a problem hiding this comment.
The explicit copy in #115093 wasn't a mistake. It was merely agnostic.
When making core changes, we don't have time to understand every single caller. So instead of trying to fix them, risking introducing bugs, we make the interface change and change callers to do the same as they did before.
Meanwhile, we hope people will in follow-ups fix the problems this kind of changes surfaces. As you do here :)
In this case it seems safe to use a reference since this is (observably) a leaf function.
Member
Author
|
Oh yeah it was meant as "this was made explicit in xyz, so the original implicit copy was probably added by accident" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The explicit copy is from #115093 so the original implicit copy was likely an accident. There is no need to copy in this situation.