Fix editor unsaved scenes getting file path updates#118225
Merged
Repiteo merged 1 commit intoMay 19, 2026
Merged
Conversation
❌ CI Report — PR #118225Repository: Checks
test build with dagger ci auto coment PR CI par |
Contributor
Author
This might be an issue with your setup, this PR doesn't do anything that could result in only the ubsan build to fail, and it builds fine on my end using gcc. I also got a linking error when trying to build with clang, so something similar might also be happening for you. |
KoBeWi
approved these changes
May 18, 2026
Member
KoBeWi
left a comment
There was a problem hiding this comment.
The problem comes from Node's set_scene_file_path() not checking if the new path is different and always calling _emit_editor_state_changed(), but the editor-side solution is less invasive.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116703
Unsaved scenes were getting their path set to another empty string every time
EditorData::get_scene_pathwas called for them. This caused a scene tree update, resulting in some jitter for resource previews. The jitter could probably be investigated further, as it would be nice for it to not happen even on scene tree updates, but this seems to solve the main problem for now.