Skip to content

OpenXR: Fix crash when using XR_EXT_frame_synthesis after Godot 4.7-dev5#118901

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
dsnopek:ext-frame-synthesis-preparation
Apr 28, 2026
Merged

OpenXR: Fix crash when using XR_EXT_frame_synthesis after Godot 4.7-dev5#118901
Repiteo merged 1 commit into
godotengine:masterfrom
dsnopek:ext-frame-synthesis-preparation

Conversation

@dsnopek
Copy link
Copy Markdown
Contributor

@dsnopek dsnopek commented Apr 23, 2026

Fixes #118902

Copy link
Copy Markdown
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems smart regardless, with on_pre_render being called from the rendering thread, it's probably a good idea to use the render state anyway.

@dsnopek
Copy link
Copy Markdown
Contributor Author

dsnopek commented Apr 24, 2026

Looking at this a bit more, I think this could be made simpler by switching from on_pre_render() to on_pre_draw_viewport(). And, we're doing our post-frame stuff in on_post_draw_viewport(), so it would have more symmetry to do the pre-frame stuff in on_pre_draw_viewport() anyway...

@dsnopek dsnopek force-pushed the ext-frame-synthesis-preparation branch from 09025ab to 412dad0 Compare April 24, 2026 09:58
@dsnopek
Copy link
Copy Markdown
Contributor Author

dsnopek commented Apr 24, 2026

I've updated this for the on_pre_draw_viewport() / on_post_draw_viewport() symmetry mentioned above

@Repiteo Repiteo merged commit ff85b79 into godotengine:master Apr 28, 2026
20 checks passed
@Repiteo
Copy link
Copy Markdown
Contributor

Repiteo commented Apr 28, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenXR: Crash when using space warp or frame synthesis in Godot 4.7-dev5 or later

3 participants