OpenXR: Fix crash when using XR_EXT_frame_synthesis after Godot 4.7-dev5#118901
Merged
Repiteo merged 1 commit intoApr 28, 2026
Merged
Conversation
BastiaanOlij
approved these changes
Apr 24, 2026
Contributor
BastiaanOlij
left a comment
There was a problem hiding this comment.
This seems smart regardless, with on_pre_render being called from the rendering thread, it's probably a good idea to use the render state anyway.
Contributor
Author
|
Looking at this a bit more, I think this could be made simpler by switching from |
09025ab to
412dad0
Compare
Contributor
Author
|
I've updated this for the |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118902