Fix subclass check when working with shallow scripts#119592
Open
Shadows-of-Fire wants to merge 1 commit into
Open
Fix subclass check when working with shallow scripts#119592Shadows-of-Fire wants to merge 1 commit into
Shadows-of-Fire wants to merge 1 commit into
Conversation
This fixes an issue with type resolution that triggers when the scripts at play are shallow, meaning the compilation pass has not been run and GDScript#base has not been populated yet. The existing logic relies on GDScript#base for validation, which (obviously) fails for shallow scripts. This adds a FQCN-based fallback path for shallow script uses. Closes godotengine#101925
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue with type resolution that triggers when the scripts at play are shallow, meaning the compilation pass has not been run and
GDScript#basehas not been populated yet. The existing logic relies onGDScript#basefor validation, which (obviously) fails for shallow scripts. This adds a FQCN-based fallback path for shallow script uses.Closes #101925