chore: enable web-dlink builds for release (#159)

nmerget · web-flow · commit 0a888c2c2b1d · 2025-12-17T12:15:34.000+01:00
* chore: enable web-dlink builds for release
chore: only build one target for main and PRs
chore: rename web builds for nothreads

* fix: bad yml syntax

* fix: wrong inputs for release

* fix: issue with fromJSON for workflows
diff --git a/.github/workflows/build_android.yml b/.github/workflows/build_android.yml
@@ -2,6 +2,9 @@ name: 🤖 Android Builds
 on:
   workflow_call:
     inputs:
+      release:
+        required: true
+        type: boolean
       version:
         required: true
         type: string
@@ -39,9 +42,8 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        engine: [v8, qjs-ng]
-        target: [template_release, template_debug]
-
+        engine: [ v8, qjs-ng ]
+        target: ${{ inputs.release && fromJSON('["template_release","template_debug"]') || fromJSON('["template_debug"]') }}
     steps:
       - name: Checkout Godot
         uses: actions/checkout@v4
diff --git a/.github/workflows/build_engine_version.yml b/.github/workflows/build_engine_version.yml
@@ -10,9 +10,9 @@ on:
         description: "Godot engine commit reference"
         required: true
         type: string
-      tests:
+      release:
         type: boolean
-        default: true
+        default: false
 
 jobs:
   android-build:
@@ -21,44 +21,47 @@ jobs:
     with:
       version: ${{ inputs.version }}
       version_ref: ${{ inputs.version_ref }}
+      release: ${{ inputs.release }}
 
   ios-build:
     name: 🍏 iOS
     uses: ./.github/workflows/build_ios.yml
     with:
       version: ${{ inputs.version }}
       version_ref: ${{ inputs.version_ref }}
+      release: ${{ inputs.release }}
 
   linux-build:
     name: 🐧 Linux
     uses: ./.github/workflows/build_linux.yml
     with:
       version: ${{ inputs.version }}
       version_ref: ${{ inputs.version_ref }}
-      tests: ${{ inputs.tests }}
+      release: ${{ inputs.release }}
 
   macos-build:
     name: 🍎 macOS
     uses: ./.github/workflows/build_macos.yml
     with:
       version: ${{ inputs.version }}
       version_ref: ${{ inputs.version_ref }}
-      tests: ${{ inputs.tests }}
+      release: ${{ inputs.release }}
 
   windows-build:
     name: 🏁 Windows
     uses: ./.github/workflows/build_windows.yml
     with:
       version: ${{ inputs.version }}
       version_ref: ${{ inputs.version_ref }}
-      tests: ${{ inputs.tests }}
+      release: ${{ inputs.release }}
 
   web-build:
     name: 🌐 Web
     uses: ./.github/workflows/build_web.yml
     with:
       version: ${{ inputs.version }}
       version_ref: ${{ inputs.version_ref }}
+      release: ${{ inputs.release }}
 
   checks-done:
     if: ${{ always() }}
diff --git a/.github/workflows/build_ios.yml b/.github/workflows/build_ios.yml
@@ -2,6 +2,9 @@ name: 🍏 iOS Builds
 on:
   workflow_call:
     inputs:
+      release:
+        required: true
+        type: boolean
       version:
         required: true
         type: string
@@ -37,8 +40,7 @@ jobs:
         # JSC isn't working at the moment
         #        engine: [ v8, qjs-ng, jsc ]
         engine: [ v8, qjs-ng ]
-        target: [ template_release, template_debug ]
-
+        target: ${{ inputs.release && fromJSON('["template_release","template_debug"]') || fromJSON('["template_debug"]') }}
     steps:
       - name: Checkout Godot
         uses: actions/checkout@v4
diff --git a/.github/workflows/build_linux.yml b/.github/workflows/build_linux.yml
@@ -2,16 +2,16 @@ name: 🐧 Linux Builds
 on:
   workflow_call:
     inputs:
+      release:
+        required: true
+        type: boolean
       version:
         required: true
         type: string
       version_ref:
         description: "Godot engine commit reference"
         required: true
         type: string
-      tests:
-        type: boolean
-        default: true
 
 # Global Settings
 env:
@@ -41,9 +41,8 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        engine: [v8, qjs-ng]
-        target: [editor, template_release, template_debug]
-
+        engine: [ v8, qjs-ng ]
+        target: ${{ inputs.release && fromJSON('["editor","template_release","template_debug"]') || fromJSON('["editor"]') }}
     steps:
       - name: Checkout Godot
         uses: actions/checkout@v4
@@ -83,7 +82,7 @@ jobs:
           path: ${{github.workspace}}/modules/GodotJS/scripts/out
 
       - name: Download tests/project
-        if: ${{ inputs.tests && matrix.target == 'editor' }}
+        if: ${{ !inputs.release && matrix.target == 'editor' }}
         uses: actions/download-artifact@v4
         with:
           name: tests-project
@@ -113,7 +112,7 @@ jobs:
             ${{ env.SCONSFLAGS }} 
             ${{ matrix.target != 'editor' && 'debug_symbols=no' || '' }} 
             ${{ matrix.engine == 'qjs-ng' && 'use_quickjs_ng=yes' || '' }} 
-            ${{ inputs.tests && matrix.target == 'editor' && 'tests=yes' || '' }}
+            ${{ !inputs.release && matrix.target == 'editor' && 'tests=yes' || '' }}
           platform: linuxbsd
           target: ${{ matrix.target }}
           scons-cache-limit: ${{ matrix.target == 'editor' && 2 || 1 }}
@@ -126,7 +125,7 @@ jobs:
             ${{ env.SCONS_FLAGS }} 
             ${{ matrix.target != 'editor' && 'debug_symbols=no' || '' }} 
             ${{ matrix.engine == 'qjs-ng' && 'use_quickjs_ng=yes' || '' }} 
-            ${{ inputs.tests && matrix.target == 'editor' && 'tests=yes' || '' }}
+            ${{ !inputs.release && matrix.target == 'editor' && 'tests=yes' || '' }}
           platform: linuxbsd
 
       - name: Save Godot build cache
@@ -146,7 +145,7 @@ jobs:
           name: linux-${{ matrix.target }}-${{inputs.version}}-${{ matrix.engine }}
 
       - name: Unit tests
-        if: ${{ inputs.tests && matrix.target == 'editor' }}
+        if: ${{ !inputs.release && matrix.target == 'editor' }}
         env:
           BIN: ./bin/godot.linuxbsd.editor.x86_64
         run: |
diff --git a/.github/workflows/build_macos.yml b/.github/workflows/build_macos.yml
@@ -2,16 +2,16 @@ name: 🍎 macOS Builds
 on:
   workflow_call:
     inputs:
+      release:
+        required: true
+        type: boolean
       version:
         required: true
         type: string
       version_ref:
         description: "Godot engine commit reference"
         required: true
         type: string
-      tests:
-        type: boolean
-        default: true
 
 # Global Settings
 env:
@@ -37,8 +37,7 @@ jobs:
       fail-fast: false
       matrix:
         engine: [v8, qjs-ng]
-        target: [editor, template_release, template_debug]
-
+        target: ${{ inputs.release && fromJSON('["editor","template_release","template_debug"]') || fromJSON('["editor"]') }}
     steps:
       - name: Select Xcode 16
         run: sudo xcode-select -s /Applications/Xcode_16.2.app
@@ -97,7 +96,7 @@ jobs:
           path: ${{github.workspace}}/modules/GodotJS/scripts/out
 
       - name: Download tests/project
-        if: ${{ inputs.tests && matrix.target == 'editor' }}
+        if: ${{ !inputs.release && matrix.target == 'editor' }}
         uses: actions/download-artifact@v4
         with:
           name: tests-project
@@ -113,7 +112,7 @@ jobs:
             ${{ matrix.engine == 'qjs-ng' && 'use_quickjs_ng=yes' || '' }} 
             arch=x86_64 
             vulkan=${{ steps.vulkan-sdk.outputs.VULKAN_ENABLED }} 
-            ${{ inputs.tests && matrix.target == 'editor' && 'tests=yes' || '' }}
+            ${{ !inputs.release && matrix.target == 'editor' && 'tests=yes' || '' }}
           platform: macos
           target: ${{ matrix.target }}
           scons-cache-limit: 0 # Only cap on second run to avoid purging unnecessarily
@@ -128,7 +127,7 @@ jobs:
             ${{ matrix.engine == 'qjs-ng' && 'use_quickjs_ng=yes' || '' }} 
             arch=x86_64 
             vulkan=${{ steps.vulkan-sdk.outputs.VULKAN_ENABLED }} 
-            ${{ inputs.tests && matrix.target == 'editor' && 'tests=yes' || '' }}
+            ${{ !inputs.release && matrix.target == 'editor' && 'tests=yes' || '' }}
           platform: macos
           target: ${{ matrix.target }}
 
@@ -142,7 +141,7 @@ jobs:
             ${{ matrix.engine == 'qjs-ng' && 'use_quickjs_ng=yes' || '' }} 
             arch=arm64 
             vulkan=${{ steps.vulkan-sdk.outputs.VULKAN_ENABLED }} 
-            ${{ inputs.tests && matrix.target == 'editor' && 'tests=yes' || '' }}
+            ${{ !inputs.release && matrix.target == 'editor' && 'tests=yes' || '' }}
           platform: macos
           target: ${{ matrix.target }}
           scons-cache-limit: ${{ matrix.target == 'editor' && 2 || 1 }}
@@ -157,7 +156,7 @@ jobs:
             ${{ matrix.engine == 'qjs-ng' && 'use_quickjs_ng=yes' || '' }} 
             arch=arm64 
             vulkan=${{ steps.vulkan-sdk.outputs.VULKAN_ENABLED }} 
-            ${{ inputs.tests && matrix.target == 'editor' && 'tests=yes' || '' }}
+            ${{ !inputs.release && matrix.target == 'editor' && 'tests=yes' || '' }}
           platform: macos
           target: ${{ matrix.target }}
 
@@ -185,7 +184,7 @@ jobs:
           name: macos-${{ matrix.target }}-${{inputs.version}}-${{ matrix.engine }}
 
       - name: Unit tests
-        if: ${{ inputs.tests && matrix.target == 'editor' }}
+        if: ${{ !inputs.release && matrix.target == 'editor' }}
         env:
           BIN: ./bin/godot.macos.editor.universal
         run: |
@@ -231,17 +230,20 @@ jobs:
 
       - name: ⏬ Download template-release
         uses: actions/download-artifact@v4
+        if: ${{ inputs.release }}
         with:
           name: macos-template_release-${{inputs.version}}-${{ matrix.engine }}
           path: macos-template_release-${{inputs.version}}-${{ matrix.engine }}
 
       - name: ⏬ Download template-debug
         uses: actions/download-artifact@v4
+        if: ${{ inputs.release }}
         with:
           name: macos-template_debug-${{inputs.version}}-${{ matrix.engine }}
           path: macos-template_debug-${{inputs.version}}-${{ matrix.engine }}
 
       - name: ⚒️ Build Template App
+        if: ${{ inputs.release }}
         run: |
           mkdir template-app
           cp -r misc/dist/macos_template.app template-app/macos_template.app
@@ -251,6 +253,7 @@ jobs:
           chmod +x template-app/macos_template.app/Contents/MacOS/godot_macos*
 
       - name: ⏫ Upload template app
+        if: ${{ inputs.release }}
         uses: actions/upload-artifact@v4
         with:
           name: macos-template-app-${{inputs.version}}-${{ matrix.engine }}
diff --git a/.github/workflows/build_web.yml b/.github/workflows/build_web.yml
@@ -2,6 +2,9 @@ name: 🌐 Web Builds
 on:
   workflow_call:
     inputs:
+      release:
+        required: true
+        type: boolean
       version:
         required: true
         type: string
@@ -34,16 +37,22 @@ env:
 jobs:
   web-template:
     runs-on: ubuntu-24.04
-    name: Web (${{ matrix.target }}, ${{ matrix.engine }}, threads=${{ matrix.threads }})
+    name: Web (${{ matrix.target }}, ${{ matrix.engine }}, threads=${{ matrix.threads }}, dlink=${{ matrix.dlink }})
     timeout-minutes: 60
     strategy:
       fail-fast: false
       matrix:
         engine: [ browser, qjs-ng ]
-        target: [ template_release, template_debug ]
-        threads: [ yes, no ]
-
+        target: ${{ inputs.release && fromJSON('["template_release","template_debug"]') || fromJSON('["template_debug"]') }}
+        threads: ${{ inputs.release && fromJSON('["yes","no"]') || fromJSON('["yes"]') }}
+        dlink: ${{ inputs.release && fromJSON('["yes","no"]') || fromJSON('["no"]') }}
     steps:
+      - name: 🧬 Generate Name
+        id: name
+        run: |
+          echo "name=web${{ matrix.dlink == 'yes' && '-dlink' || '' }}${{ matrix.threads == 'no' && '-nothreads' || '' }}-${{ matrix.target }}-${{inputs.version}}-${{ matrix.engine }}" >> $GITHUB_OUTPUT
+        shell: bash
+
       - name: Checkout Godot
         uses: actions/checkout@v4
         with:
@@ -95,7 +104,7 @@ jobs:
       - name: Restore Godot build cache
         uses: ./.github/actions/godot-cache-restore
         with:
-          cache-name: web-${{ matrix.threads }}-${{ matrix.target }}-${{inputs.version}}-${{ matrix.engine }}
+          cache-name: ${{ steps.name.outputs.name }}
         continue-on-error: true
 
       - name: Setup Python and SCons
@@ -125,10 +134,10 @@ jobs:
       - name: Save Godot build cache
         uses: ./.github/actions/godot-cache-save
         with:
-          cache-name: web-${{ matrix.threads }}-${{ matrix.target }}-${{inputs.version}}-${{ matrix.engine }}
+          cache-name: ${{ steps.name.outputs.name }}
         continue-on-error: true
 
       - name: Upload artifact
         uses: ./.github/actions/upload-artifact
         with:
-          name: web-${{ matrix.threads }}-${{ matrix.target }}-${{inputs.version}}-${{ matrix.engine }}
+          name: ${{ steps.name.outputs.name }}
diff --git a/.github/workflows/build_windows.yml b/.github/workflows/build_windows.yml
diff --git a/.github/workflows/misc_upload_assets.yml b/.github/workflows/misc_upload_assets.yml
diff --git a/.github/workflows/runner.yml b/.github/workflows/runner.yml
