Revert mb_trim to trim for broader PHP support#92
Merged
Conversation
7d22281 to
2dba365
Compare
2dba365 to
a6f7c6b
Compare
|
How did the tests pass with this? |
Contributor
Author
|
I assume those code-paths are currently not covered by any tests. |
|
I checked — the code is covered by tests. However, during test execution, dev dependencies are installed, including symfony/polyfill-mbstring, which helps the tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts mb_trim changes in #91.
This was introduced by cs-fixer, but is only available in PHP 8.4+ (https://www.php.net/releases/8.4/en.php), resulting in fatal errors on lower versions.
(Sorry :-) )