-
Notifications
You must be signed in to change notification settings - Fork 84
feat(redis): use testcontainers in rueidis and valkey #1723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
1f42b00
fix(benchmarks): re-add redis install for ruedis and valkey
mdelapenya b90664b
feat: add a test module for testing redis and friends
mdelapenya 76a7b0a
chore: support for overriding the redis image
mdelapenya 05b5be3
chore: consume the testredis module in redis
mdelapenya 5b7af06
chore: consume the testredis module in rueidis
mdelapenya 892e6fe
chore: consume the testredis module in valkey
mdelapenya 7866e27
chore: remove shell script for cert generation
mdelapenya dd7391a
chore(ci): exclude testhelpers root dir from the filters
mdelapenya ba60ab9
fix: indentation
mdelapenya b7893d7
fix: do not run benchmarks for the helpers
mdelapenya abdb9c7
Merge branch 'main' into fix-ruedis-benchmarks
mdelapenya a77e60f
chore: add tests for the helper module
mdelapenya 46267c6
Merge branch 'main' into fix-ruedis-benchmarks
mdelapenya b85c022
Merge branch 'main' into fix-ruedis-benchmarks
mdelapenya 30b2073
chore: verify mtls properly in tests
mdelapenya 941ef46
chore: add integration tests to the redis helper module
mdelapenya 5794b50
chore: proper parallel layout
mdelapenya 1e6e787
fix: missing eval of redis image from env var
mdelapenya 4d516c3
chore: pass the redis-like image explicitly in tests
mdelapenya 331a84b
fix: reuse valkey container in benchmarks
mdelapenya 168125a
chore: refine message
mdelapenya ba248c9
chore: align valkey expiration test with redis
mdelapenya 4c19cba
chore: skip cluster tests
mdelapenya 288cedb
chore: align ruedis expiration test with redis
mdelapenya bf7c309
chore: read redis image for ruedis
mdelapenya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| - main | ||
| paths: | ||
| - 'testhelpers/redis/**' | ||
| pull_request: | ||
| paths: | ||
| - 'testhelpers/redis/**' | ||
| name: "Tests TestHelper Redis" | ||
| jobs: | ||
| Tests: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| go-version: | ||
| - 1.23.x | ||
| - 1.24.x | ||
| redis: | ||
| - '6' | ||
| - '7' | ||
| steps: | ||
| - name: Fetch Repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: '${{ matrix.go-version }}' | ||
|
|
||
| - name: Run Test | ||
| env: | ||
| TEST_REDIS_IMAGE: "docker.io/redis:${{ matrix.redis }}" | ||
| working-directory: testhelpers/redis | ||
| run: go test ./... -v -race |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: the helper tests won't be executed because of this. Have you considered moving to
go.workso that it's easier to identify the module paths?