Fix: Nil pointer panic in WriteMessageToSocket when WebSocket connection not found#3216
Merged
Umang01-hash merged 4 commits intoApr 7, 2026
Conversation
GetConnectionFromContext can return nil when no WebSocket connection exists in the context, causing a nil pointer panic. Add a nil check to return ErrConnectionNotFound instead of panicking. Fixes gofr-dev#3213
NitinKumar004
force-pushed
the
fix/nil-pointer-write-message-to-socket
branch
from
315a516 to
5ef1f7a
Compare
Umang01-hash
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WriteMessageToSocketto returnErrConnectionNotFoundinstead of panicking when no connection exists in the context.Fixes #3213
Test plan
TestContext_WriteMessageToSocket_NilConnectionunit test