cleanup: remove deprecated RepoXxx wrapper functions

Remove all deprecated functions that were marked with // Deprecated: Use Xxx instead.
These were wrapper functions that provided no additional value over the top-level
functions or Repository methods.

Removed functions:
- RepoPush, RepoCheckout, RepoReset, RepoMove, RepoAdd, RepoCommit
- RepoShowNameStatus, RepoCountObjects, RepoFsck
- RepoLog, RepoDiffNameOnly
- RepoShowRefVerify, RepoHasTag, RepoDeleteBranch
- RepoAddRemote, RepoRemoveRemote, RepoMergeBase
- AddRemoteOptions type alias, RemoveRemoteOptions type alias
- Repository.AddRemote, Repository.RemoveRemote methods

This reduces the API surface and eliminates tech debt for v2.

Author: unknwon

repo.go

@@ -266,11 +266,6 @@ func Push(repoPath, remote, branch string, opts ...PushOptions) error {
 	return err
 }
 
-// Deprecated: Use Push instead.
-func RepoPush(repoPath, remote, branch string, opts ...PushOptions) error {
-	return Push(repoPath, remote, branch, opts...)
-}
-
 // Push pushes local changes to given remote and branch for the repository.
 func (r *Repository) Push(remote, branch string, opts ...PushOptions) error {
 	return Push(r.path, remote, branch, opts...)
@@ -311,11 +306,6 @@ func Checkout(repoPath, branch string, opts ...CheckoutOptions) error {
 	return err
 }
 
-// Deprecated: Use Checkout instead.
-func RepoCheckout(repoPath, branch string, opts ...CheckoutOptions) error {
-	return Checkout(repoPath, branch, opts...)
-}
-
 // Checkout checks out to given branch for the repository.
 func (r *Repository) Checkout(branch string, opts ...CheckoutOptions) error {
 	return Checkout(r.path, branch, opts...)
@@ -352,11 +342,6 @@ func Reset(repoPath, rev string, opts ...ResetOptions) error {
 	return err
 }
 
-// Deprecated: Use Reset instead.
-func RepoReset(repoPath, rev string, opts ...ResetOptions) error {
-	return Reset(repoPath, rev, opts...)
-}
-
 // Reset resets working tree to given revision for the repository.
 func (r *Repository) Reset(rev string, opts ...ResetOptions) error {
 	return Reset(r.path, rev, opts...)
@@ -388,11 +373,6 @@ func Move(repoPath, src, dst string, opts ...MoveOptions) error {
 	return err
 }
 
-// Deprecated: Use Move instead.
-func RepoMove(repoPath, src, dst string, opts ...MoveOptions) error {
-	return Move(repoPath, src, dst, opts...)
-}
-
 // Move moves a file, a directory, or a symlink file or directory from source to
 // destination for the repository.
 func (r *Repository) Move(src, dst string, opts ...MoveOptions) error {
@@ -435,11 +415,6 @@ func Add(repoPath string, opts ...AddOptions) error {
 	return err
 }
 
-// Deprecated: Use Add instead.
-func RepoAdd(repoPath string, opts ...AddOptions) error {
-	return Add(repoPath, opts...)
-}
-
 // Add adds local changes to index for the repository.
 func (r *Repository) Add(opts ...AddOptions) error {
 	return Add(r.path, opts...)
@@ -486,11 +461,6 @@ func CreateCommit(repoPath string, committer *Signature, message string, opts ..
 	return err
 }
 
-// Deprecated: Use CreateCommit instead.
-func RepoCommit(repoPath string, committer *Signature, message string, opts ...CommitOptions) error {
-	return CreateCommit(repoPath, committer, message, opts...)
-}
-
 // Commit commits local changes with given author, committer and message for the
 // repository.
 func (r *Repository) Commit(committer *Signature, message string, opts ...CommitOptions) error {
@@ -562,11 +532,6 @@ func ShowNameStatus(repoPath, rev string, opts ...ShowNameStatusOptions) (*NameS
 	return fileStatus, nil
 }
 
-// Deprecated: Use ShowNameStatus instead.
-func RepoShowNameStatus(repoPath, rev string, opts ...ShowNameStatusOptions) (*NameStatus, error) {
-	return ShowNameStatus(repoPath, rev, opts...)
-}
-
 // ShowNameStatus returns name status of given revision of the repository.
 func (r *Repository) ShowNameStatus(rev string, opts ...ShowNameStatusOptions) (*NameStatus, error) {
 	return ShowNameStatus(r.path, rev, opts...)
@@ -675,11 +640,6 @@ func CountObjects(repoPath string, opts ...CountObjectsOptions) (*CountObject, e
 	return countObject, nil
 }
 
-// Deprecated: Use CountObjects instead.
-func RepoCountObjects(repoPath string, opts ...CountObjectsOptions) (*CountObject, error) {
-	return CountObjects(repoPath, opts...)
-}
-
 // CountObjects returns disk usage report of the repository.
 func (r *Repository) CountObjects(opts ...CountObjectsOptions) (*CountObject, error) {
 	return CountObjects(r.path, opts...)
@@ -711,11 +671,6 @@ func Fsck(repoPath string, opts ...FsckOptions) error {
 	return err
 }
 
-// Deprecated: Use Fsck instead.
-func RepoFsck(repoPath string, opts ...FsckOptions) error {
-	return Fsck(repoPath, opts...)
-}
-
 // Fsck verifies the connectivity and validity of the objects in the database
 // for the repository.
 func (r *Repository) Fsck(opts ...FsckOptions) error {

repo_commit.go

@@ -206,11 +206,6 @@ func Log(repoPath, rev string, opts ...LogOptions) ([]*Commit, error) {
 	return r.Log(rev, opts...)
 }
 
-// Deprecated: Use Log instead.
-func RepoLog(repoPath, rev string, opts ...LogOptions) ([]*Commit, error) {
-	return Log(repoPath, rev, opts...)
-}
-
 // Log returns a list of commits in the state of given revision of the repository.
 // The returned list is in reverse chronological order.
 func (r *Repository) Log(rev string, opts ...LogOptions) ([]*Commit, error) {
@@ -434,11 +429,6 @@ func DiffNameOnly(repoPath, base, head string, opts ...DiffNameOnlyOptions) ([]s
 	return names, nil
 }
 
-// Deprecated: Use DiffNameOnly instead.
-func RepoDiffNameOnly(repoPath, base, head string, opts ...DiffNameOnlyOptions) ([]string, error) {
-	return DiffNameOnly(repoPath, base, head, opts...)
-}
-
 // DiffNameOnly returns a list of changed files between base and head revisions of the
 // repository.
 func (r *Repository) DiffNameOnly(base, head string, opts ...DiffNameOnlyOptions) ([]string, error) {

repo_pull.go

@@ -46,11 +46,6 @@ func MergeBase(repoPath, base, head string, opts ...MergeBaseOptions) (string, e
 	return strings.TrimSpace(string(stdout)), nil
 }
 
-// Deprecated: Use MergeBase instead.
-func RepoMergeBase(repoPath, base, head string, opts ...MergeBaseOptions) (string, error) {
-	return MergeBase(repoPath, base, head, opts...)
-}
-
 // MergeBase returns merge base between base and head revisions of the
 // repository.
 func (r *Repository) MergeBase(base, head string, opts ...MergeBaseOptions) (string, error) {

repo_reference.go

@@ -67,11 +67,6 @@ func ShowRefVerify(repoPath, ref string, opts ...ShowRefVerifyOptions) (string,
 	return strings.Split(string(stdout), " ")[0], nil
 }
 
-// Deprecated: Use ShowRefVerify instead.
-func RepoShowRefVerify(repoPath, ref string, opts ...ShowRefVerifyOptions) (string, error) {
-	return ShowRefVerify(repoPath, ref, opts...)
-}
-
 // ShowRefVerify returns the commit ID of given reference (e.g.
 // "refs/heads/master") if it exists in the repository.
 func (r *Repository) ShowRefVerify(ref string, opts ...ShowRefVerifyOptions) (string, error) {
@@ -110,11 +105,6 @@ func HasTag(repoPath, tag string, opts ...ShowRefVerifyOptions) bool {
 	return RepoHasReference(repoPath, RefsTags+tag, opts...)
 }
 
-// Deprecated: Use HasTag instead.
-func RepoHasTag(repoPath, tag string, opts ...ShowRefVerifyOptions) bool {
-	return HasTag(repoPath, tag, opts...)
-}
-
 // HasReference returns true if given reference exists in the repository. The
 // reference must be given in full refspec, e.g. "refs/heads/master".
 func (r *Repository) HasReference(ref string, opts ...ShowRefVerifyOptions) bool {
@@ -285,11 +275,6 @@ func DeleteBranch(repoPath, name string, opts ...DeleteBranchOptions) error {
 	return err
 }
 
-// Deprecated: Use DeleteBranch instead.
-func RepoDeleteBranch(repoPath, name string, opts ...DeleteBranchOptions) error {
-	return DeleteBranch(repoPath, name, opts...)
-}
-
 // DeleteBranch deletes the branch from the repository.
 func (r *Repository) DeleteBranch(name string, opts ...DeleteBranchOptions) error {
 	return DeleteBranch(r.path, name, opts...)

repo_remote.go

@@ -103,9 +103,6 @@ type RemoteAddOptions struct {
 	CommandOptions
 }
 
-// Deprecated: Use RemoteAddOptions instead.
-type AddRemoteOptions = RemoteAddOptions
-
 // RemoteAdd adds a new remote to the repository in given path.
 func RemoteAdd(repoPath, name, url string, opts ...RemoteAddOptions) error {
 	var opt RemoteAddOptions
@@ -125,21 +122,11 @@ func RemoteAdd(repoPath, name, url string, opts ...RemoteAddOptions) error {
 	return err
 }
 
-// Deprecated: Use RemoteAdd instead.
-func RepoAddRemote(repoPath, name, url string, opts ...RemoteAddOptions) error {
-	return RemoteAdd(repoPath, name, url, opts...)
-}
-
 // RemoteAdd adds a new remote to the repository.
 func (r *Repository) RemoteAdd(name, url string, opts ...RemoteAddOptions) error {
 	return RemoteAdd(r.path, name, url, opts...)
 }
 
-// Deprecated: Use RemoteAdd instead.
-func (r *Repository) AddRemote(name, url string, opts ...RemoteAddOptions) error {
-	return RemoteAdd(r.path, name, url, opts...)
-}
-
 // RemoteRemoveOptions contains arguments for removing a remote from the
 // repository.
 //
@@ -154,9 +141,6 @@ type RemoteRemoveOptions struct {
 	CommandOptions
 }
 
-// Deprecated: Use RemoteRemoveOptions instead.
-type RemoveRemoteOptions = RemoteRemoveOptions
-
 // RemoteRemove removes a remote from the repository in given path.
 func RemoteRemove(repoPath, name string, opts ...RemoteRemoveOptions) error {
 	var opt RemoteRemoveOptions
@@ -179,21 +163,11 @@ func RemoteRemove(repoPath, name string, opts ...RemoteRemoveOptions) error {
 	return nil
 }
 
-// Deprecated: Use RemoteRemove instead.
-func RepoRemoveRemote(repoPath, name string, opts ...RemoteRemoveOptions) error {
-	return RemoteRemove(repoPath, name, opts...)
-}
-
 // RemoteRemove removes a remote from the repository.
 func (r *Repository) RemoteRemove(name string, opts ...RemoteRemoveOptions) error {
 	return RemoteRemove(r.path, name, opts...)
 }
 
-// Deprecated: Use RemoteRemove instead.
-func (r *Repository) RemoveRemote(name string, opts ...RemoteRemoveOptions) error {
-	return RemoteRemove(r.path, name, opts...)
-}
-
 // RemotesOptions contains arguments for listing remotes of the repository.
 // /
 // Docs: https://git-scm.com/docs/git-remote#_commands