src/goTest: fix multifile suite test fails to debug by nirhaas · Pull Request #2415 · golang/vscode-go

nirhaas · 2022-08-15T23:02:03Z

Collect a packages suites and maps their name with the caller function. This mapping is used to fix a bug where vscode-go was formatting wrong arguments for dlv (-test.run).

Fixes #2414

gopherbot · 2022-08-15T23:08:47Z

This PR (HEAD: 1a9b381) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/424094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-08-18T18:41:28Z

Message from Suzy Mueller:

Patch Set 1:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-08-18T19:12:18Z

This PR (HEAD: 1ab2947) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/424094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-08-18T20:22:58Z

Message from Nir Haas:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-08-18T20:27:16Z

Message from Suzy Mueller:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-08-18T20:48:45Z

Message from Nir Haas:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-08-25T19:21:20Z

Message from Nir Haas:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-08-29T18:07:15Z

Message from Suzy Mueller:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-01T13:47:00Z

Message from Suzy Mueller:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-02T19:04:33Z

This PR (HEAD: c97e661) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/424094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-09-02T19:09:30Z

This PR (HEAD: 09deeca) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/424094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-09-02T19:18:36Z

Message from Nir Haas:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-04T18:27:17Z

Message from Nir Haas:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-12T16:03:34Z

Message from Suzy Mueller:

Patch Set 4: Code-Review+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-12T18:43:25Z

Message from Suzy Mueller:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-12T19:11:15Z

Message from Hyang-Ah Hana Kim:

Patch Set 4: Auto-Submit+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-12T19:11:16Z

Message from Hyang-Ah Hana Kim:

Patch Set 4: Run-TryBot+1 -Auto-Submit

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-12T19:20:43Z

Message from kokoro:

Patch Set 4:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/16780e7b-5957-419f-96ae-b57ac3fcc7c1

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-12T19:20:44Z

Message from kokoro:

Patch Set 4: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/16780e7b-5957-419f-96ae-b57ac3fcc7c1

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-14T16:21:55Z

Message from Jamal Carvalho:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-14T17:02:09Z

This PR (HEAD: 19b8cd4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/424094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-09-14T17:42:39Z

Message from Nir Haas:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-19T14:51:18Z

Message from Jamal Carvalho:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-19T14:56:14Z

Message from kokoro:

Patch Set 5:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/a26112ed-f26d-470f-8b28-d0868baa3efa

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-19T17:56:53Z

Message from kokoro:

Patch Set 5: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/a26112ed-f26d-470f-8b28-d0868baa3efa

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-20T08:33:08Z

Message from Nir Haas:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-20T13:50:16Z

Message from Jamal Carvalho:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-20T13:55:08Z

Message from kokoro:

Patch Set 5:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/0cf44da8-6f10-428d-868b-1a378fe664c9

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-20T14:00:09Z

Message from kokoro:

Patch Set 5: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/0cf44da8-6f10-428d-868b-1a378fe664c9

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-10-03T09:37:49Z

Message from Nir Haas:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-25T13:18:16Z

Message from Morten Gerdes:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-25T15:52:39Z

Message from Hyang-Ah Hana Kim:

Patch Set 5: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/424094.
After addressing review feedback, remember to publish your drafts!

I have resumed the pull request #2415 and added the missing tests. Here is the original description: Collect a packages suites and maps their name with the caller function. This mapping is used to fix a bug where vscode-go was formatting wrong arguments for dlv (-test.run). Fixes #2414 Change-Id: Id6ac5d153fa1dbcdb7591b2bd0ee78bfa95686c6 GitHub-Last-Rev: 0fa9525 GitHub-Pull-Request: #3128 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/555676 Reviewed-by: Than McIntosh <thanm@google.com> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com> Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>

nirhaas changed the title ~~fix multifile suite test fails to debug~~ src/goTest: fix multifile suite test fails to debug Aug 18, 2022

nirhaas force-pushed the nhaas/fix_debug_multifile_test_suite branch from 1a9b381 to 1ab2947 Compare August 18, 2022 19:11

nirhaas force-pushed the nhaas/fix_debug_multifile_test_suite branch from 1ab2947 to c97e661 Compare September 2, 2022 18:59

nirhaas force-pushed the nhaas/fix_debug_multifile_test_suite branch from c97e661 to 09deeca Compare September 2, 2022 19:09

src/goTest: fix multifile suite test fails to debug

19b8cd4

nirhaas force-pushed the nhaas/fix_debug_multifile_test_suite branch from 09deeca to 19b8cd4 Compare September 14, 2022 16:57

divmgl mentioned this pull request Nov 9, 2022

Failure to debug a suite test that is in a different file than the caller test #2414

Closed

Cr4zySheep mentioned this pull request Jan 14, 2024

src/goTest: fix multifile suite test fails to debug #3128

Closed

Conversation

nirhaas commented Aug 15, 2022

Uh oh!

gopherbot commented Aug 15, 2022

Uh oh!

gopherbot commented Aug 18, 2022

Uh oh!

gopherbot commented Aug 18, 2022

Uh oh!

gopherbot commented Aug 18, 2022

Uh oh!

gopherbot commented Aug 18, 2022

Uh oh!

gopherbot commented Aug 18, 2022

Uh oh!

gopherbot commented Aug 25, 2022

Uh oh!

gopherbot commented Aug 29, 2022

Uh oh!

gopherbot commented Sep 1, 2022

Uh oh!

gopherbot commented Sep 2, 2022

Uh oh!

gopherbot commented Sep 2, 2022

Uh oh!

gopherbot commented Sep 2, 2022

Uh oh!

gopherbot commented Sep 4, 2022

Uh oh!

gopherbot commented Sep 12, 2022

Uh oh!

gopherbot commented Sep 12, 2022

Uh oh!

gopherbot commented Sep 12, 2022

Uh oh!

gopherbot commented Sep 12, 2022

Uh oh!

gopherbot commented Sep 12, 2022

Uh oh!

gopherbot commented Sep 12, 2022

Uh oh!

gopherbot commented Sep 14, 2022

Uh oh!

gopherbot commented Sep 14, 2022

Uh oh!

gopherbot commented Sep 14, 2022

Uh oh!

gopherbot commented Sep 19, 2022

Uh oh!

gopherbot commented Sep 19, 2022

Uh oh!

gopherbot commented Sep 19, 2022

Uh oh!

gopherbot commented Sep 20, 2022

Uh oh!

gopherbot commented Sep 20, 2022

Uh oh!

gopherbot commented Sep 20, 2022

Uh oh!

gopherbot commented Sep 20, 2022

Uh oh!

gopherbot commented Oct 3, 2022

Uh oh!

gopherbot commented Oct 25, 2023

Uh oh!

gopherbot commented Oct 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants