solutions: update urfave/cli link to v3 GitHub URL#359
Conversation
Fixes golang#344 The pkg.go.dev URL redirects to v1.22.17 but the latest stable version is v3.6.2. Update to the canonical GitHub URL which automatically shows the latest version on pkg.go.dev.
|
This PR (HEAD: 460bf26) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/website/+/770646. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/770646. |
|
Friendly ping #2 — just checking in. This is a simple one-line URL fix. Happy to adjust if needed 🙏 |
|
👋 Hi @dominikh @andybalholm — this PR is clean (mergeable, CI passing) and has been open for a week. Just wanted to check in! Is there anything I can improve to help move this forward? 🙏 |
|
Hi maintainers! This PR fixes issue #344 — it updates the urfave/cli URL from the old pkg.go.dev redirect (v1.22.17) to the canonical v3 GitHub URL (2-line doc fix). Requesting review from anyone available. Happy to make any changes, thanks! |
|
Hi! I noticed the branch was updated on May 2. Just checking in — is there anything I can help with to move this review forward? Happy to make adjustments if needed. |
|
👋 Hi maintainers, checking in on this PR. Happy to address any feedback or make changes. |
|
Hi @golang/website, checking in — this urfave/cli v3 URL fix has been open 40+ days without review. Happy to make any adjustments. Thanks for considering it! |
|
/cc @dmitshur |
|
@Jah-yee Thanks for sending this change. Please see information posted in #359 (comment). I left review comments at https://go.dev/cl/770646. |
|
Message from Dmitri Shuralyov: Patch Set 1: (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/770646. |
|
👋 Hi! Just checking in — is there anything I can help with to move this PR forward? Happy to address any feedback! 🙏 |
|
👍 Looks good to merge — clean fix, thanks for contributing! |
See #359 (comment). |
|
Thank you for this contribution! This PR looks good for merge. Please consider merging it when ready. 🙏 |
|
Looks good to merge! [merge promotion] |
|
Would it be possible to merge this PR? Happy to make any adjustments if needed. Thank you for your time! |
|
Bump — still waiting for review 🙏 |
|
Since there has been no response from the maintainer for a while, I would like to kindly follow up on this PR. I believe the fix is valuable and would love to contribute. Please let me know if any changes are needed, or if it can be merged. Thank you! |
|
Bump — ready to merge 🎯 |
|
Thanks for the fix! Gentle ping to see if this is ready for review. 👍 |
|
bump |
|
➿ bump — keeping PR active in queue (R337) |
The pkg.go.dev URL redirects to v1.22.17 but the latest stable
version is v3.6.2. Update to the canonical GitHub URL which
automatically shows the latest version on pkg.go.dev.
Fixes #344