[Vietnamese Translation] Need help about contributing#162
Draft
ngthuongdoan wants to merge 7 commits intogoldbergyoni:masterfrom
Draft
[Vietnamese Translation] Need help about contributing#162ngthuongdoan wants to merge 7 commits intogoldbergyoni:masterfrom
ngthuongdoan wants to merge 7 commits intogoldbergyoni:masterfrom
Conversation
ngthuongdoan
changed the title
|
HI, I should continue to contribute in your repo. You can change this PR to a draft, I think is the best option, when you are ready change the PR to active and ask to approval here. |
Owner
|
@ngthuongdoan Sorry for the late reply, I was on paternity leave. Looks like a great start 🚀! What we typically do is creating a dedicated branch here for the translation, then your PR should target this branch. I've already created one for you which is called 'translations-draft-vietnamese'. Does this make sense? You can also work with @brunopenso on your repo and then occasionally save your progress to 'translations-draft-vietnamese'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @goldbergyoni, this is the first time I contribute to another repo 🥲. I don't know how to do next.
Currently, I've done some first paragraph on my forked repo. You said that I make a PR, and then what should I do next?
Continue to translate on master branch on my forked or what?