test(benchmark): add cloud benchmark suites and CloudMode fixes for running them#3644
Open
kmatasfp wants to merge 2 commits into
Open
test(benchmark): add cloud benchmark suites and CloudMode fixes for running them#3644kmatasfp wants to merge 2 commits into
kmatasfp wants to merge 2 commits into
Conversation
✅ Deploy Preview for golemcloud canceled.
|
vigoo
reviewed
Jun 18, 2026
| #[derive(Debug, Clone, PartialEq, Serialize, Deserialize)] | ||
| pub struct BenchmarkSuiteResult { | ||
| /// Result format version. Always `1` for results produced by this binary. | ||
| pub schema_version: u32, |
Contributor
There was a problem hiding this comment.
This needs a default, because on the daily CI benchmark run we append results to an old result file (that is rendered at https://golemcloud.github.io/benchmark-results/)
vigoo
reviewed
Jun 18, 2026
| std::env::var(key).ok().filter(|v| !v.is_empty()) | ||
| } | ||
| fn env_u32(key: &str) -> Option<u32> { | ||
| env_str(key).and_then(|v| v.parse().ok()) |
Contributor
There was a problem hiding this comment.
I would panic if the env var is set but not a number, to avoid confusion
vigoo
requested changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.