Skip to content

Avoid reactivating rpc targets during replay #3669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vigoo merged 3 commits into from
Jun 29, 2026
Merged

Avoid reactivating rpc targets during replay #3669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
747c680
Avoid reactivating rpc targets during replay
vigoo Jun 26, 2026
8d2677a
incomplete-new fix and cleanup
vigoo Jun 26, 2026
77401d6
Review comment fixes
vigoo Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions golem-common/src/model/oplog/payload/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1387,10 +1387,30 @@ impl From<SerializableIpAddresses> for Vec<IpAddress> {
#[desert(evolution())]
pub enum SerializableInvokeResult {
Failed(String),
FailedClassified {
kind: SerializableHostFailureKind,
message: String,
},
Pending,
Completed(Result<SchemaValue, SerializableRpcError>),
}

#[derive(
Debug,
Clone,
Copy,
PartialEq,
Eq,
BinaryCodec,
golem_schema_derive::IntoSchema,
golem_schema_derive::FromSchema,
)]
#[desert(evolution())]
pub enum SerializableHostFailureKind {
Transient,
Permanent,
}

#[derive(
Debug,
Clone,
Expand Down
Loading
Loading