Skip to content

Commit baa71d7

Browse files
authored
Merge pull request #31 from gomicro/more-error-fixes
more error fixes
2 parents 5aea968 + 8ba56a2 commit baa71d7

2 files changed

Lines changed: 14 additions & 7 deletions

File tree

.golangci.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ linters:
2929
- path: cmd
3030
linters:
3131
- forbidigo
32+
- path: confile
33+
linters:
34+
- forbidigo
3235
- path: fmt
3336
linters:
3437
- forbidigo

confile/step.go

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,31 +35,31 @@ func (s *Step) Execute(allSteps map[string]*Step, projectEnvs map[string]string,
3535
if len(s.Pre) > 0 && !skipPre {
3636
err := s.executeSteps(s.Pre, allSteps)
3737
if err != nil {
38-
return fmt.Errorf("step: execute pre: %v", err.Error())
38+
return fmt.Errorf("step: execute pre: %w", err)
3939
}
4040
}
4141

4242
if len(s.Steps) > 0 {
4343
err := s.executeSteps(s.Steps, allSteps)
4444
if err != nil {
45-
return fmt.Errorf("step: execute steps: %v", err.Error())
45+
return fmt.Errorf("step: execute steps: %w", err)
4646
}
4747
} else if len(s.Cmds) > 0 {
4848
err := s.executeCmds()
4949
if err != nil {
50-
return fmt.Errorf("step: execute cmds: %v", err.Error())
50+
return fmt.Errorf("step: execute cmds: %w", err)
5151
}
5252
} else {
5353
err := s.executeCmd()
5454
if err != nil {
55-
return fmt.Errorf("step: execute cmd: %v", err.Error())
55+
return fmt.Errorf("step: execute cmd: %w", err)
5656
}
5757
}
5858

5959
if len(s.Post) > 0 && !skipPost {
6060
err := s.executeSteps(s.Post, allSteps)
6161
if err != nil {
62-
return fmt.Errorf("step: execute post: %v", err.Error())
62+
return fmt.Errorf("step: execute post: %w", err)
6363
}
6464
}
6565

@@ -77,7 +77,7 @@ func (s *Step) executeCmds() error {
7777

7878
err := executeCmd(cmdString, s.Envs, s.projectEnvs, s.vars)
7979
if err != nil {
80-
return fmt.Errorf("cmds: cmd exec: %v", err.Error())
80+
return fmt.Errorf("cmds: cmd exec: %w", err)
8181
}
8282
}
8383

@@ -101,6 +101,10 @@ func (s *Step) executeSteps(execList []string, allSteps map[string]*Step) error
101101
}
102102

103103
func executeCmd(cmdString string, stepEnvs, projectEnvs map[string]string, vars *vars.Vars) error {
104+
if viper.GetBool("verbose") {
105+
fmt.Printf("$ %s\n", cmdString)
106+
}
107+
104108
cmd := exec.Command("bash", "-c", cmdString)
105109

106110
cmd.Env = toSlice(stepEnvs)
@@ -116,7 +120,7 @@ func executeCmd(cmdString string, stepEnvs, projectEnvs map[string]string, vars
116120
cmd.Stderr = os.Stderr
117121
err := cmd.Start()
118122
if err != nil {
119-
return fmt.Errorf("execute: %v", err.Error())
123+
return fmt.Errorf("execute: %w", err)
120124
}
121125

122126
return cmd.Wait()

0 commit comments

Comments
 (0)