feat: Support for image resizing inside Markdown text#376
Conversation
d99a1fa to
3b4c9e2
Compare
| if let size { | ||
| if let width = size.width, let height = size.height { | ||
| content.frame(width: width, height: height) | ||
| } else if let width = size.width, size.height == nil { | ||
| content.frame(width: width) | ||
| } else if let height = size.height, size.width == nil { | ||
| content.frame(height: height) | ||
| } else { | ||
| content | ||
| } | ||
| } else { | ||
| content | ||
| } |
There was a problem hiding this comment.
The width and height parameters of the frame ViewModifier are optional, so it should be possible to do just:
content.frame(width: size?.width, height: size?.height)
There was a problem hiding this comment.
You're absolutely right. I'm making the change.
| /// - {width=50px} | ||
| /// - {height=50px} | ||
| /// - {width=50px height=100px} | ||
| /// - {height=50px width=100px} |
There was a problem hiding this comment.
It would be awesome if it also supported proportional width and height
e.g. {width=50%}
There was a problem hiding this comment.
Yes I thought about it too. Can be quickly achieve for iOS 17+ with the new containerRelativeFrame modifier for horizontal configuration.
But I'm not sure of what 50% height would mean in the context of a vertical scrolling view. Does it mean 50% of the scrollview content, 50% of the nearest block where the content is, ... Depending on the answer could be harder to implement.
I've draft a commit to demonstrate horizontal relative width handling.
This is a cat with {width=50%}
There was a problem hiding this comment.
I wouldn't support relative height in the vertically scrollable ScrollView and relative width in the horizontally scrollable ScrollView. GeometryReader also "doesn't work" in these cases and returns a size equal to 10, but I think it's fine because these use cases don't make much sense and users of this framework would be also confused about what the 100 % actually is.
The containerRelativeFrame is cool but unfortunately supported just by iOS 17+, as you mentioned.
GeometryReader could be utilized, so it also supports older iOS.
Here is an example of the relative sizes:
.
There was a problem hiding this comment.
I've submitted a new commit using GeometryReader to handle relative width size.
336f136 to
47c147a
Compare
paul1893
changed the title
|
I agree |
3 participants
Hello 👋,
I'm not sure if this has been discussed already, as I didn't see anything directly related in the "Issues" section.
In some forms of markdown, you can specify the size of an image (like in GitLab, for example) in this way:
{width=50px}With the following variations:
{width=50px}{width=50px height=50px}{height=50px width=50px}{height=50px}I'm not an expert in markdown, so I'm unsure if resizing an image follows a specific convention or if it even makes sense to be supported directly by Swift-Markdown-UI. Perhaps the library already supports it?
<img width="600" alt="x" src="y" />doesn't seem to be interpreted for example.Feel free to close this PR if it doesn't make sense or need to be supported in another way.
Regardless, great library 👏 Thanks.