Skip to content

fix(lm): retry HTTP 408 from the HF CDN in the hub retry backend #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danbraunai-goodfire merged 1 commit into from
Jun 29, 2026
Merged

fix(lm): retry HTTP 408 from the HF CDN in the hub retry backend #561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions param_decomp_lab/infra/hf_http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
adapter for metadata calls like `HfApi.repo_info` — the call `datasets` makes to resolve
a streaming dataset's layout at startup. A single `ReadTimeout` there raises, and in a
DDP job that one rank's failure tears down every rank before training begins. This mounts
a retrying adapter on the session factory so connect/read timeouts and 5xx/429 are
a retrying adapter on the session factory so connect/read timeouts and 408/429/5xx are
retried with jittered backoff across *all* Hub HTTP calls (dataset, tokenizer, model).
"""

Expand Down Expand Up @@ -36,7 +36,7 @@ def configure_hf_http_retries(*, total_retries: int = 5, backoff_factor: float =
status=total_retries,
backoff_factor=backoff_factor,
backoff_jitter=1.0,
status_forcelist=(429, 500, 502, 503, 504),
status_forcelist=(408, 429, 500, 502, 503, 504),
allowed_methods=frozenset({"GET", "HEAD", "OPTIONS"}),
respect_retry_after_header=True,
raise_on_status=False,
Expand Down