Fix std::max type mismatch for size_t Rank (portable across platforms)#6734
Merged
copybara-service[bot] merged 1 commit intoApr 13, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
… such as armv7-a in 32 bits)
aecc6ba to
572b37b
Compare
snnn
approved these changes
Apr 3, 2026
5492ef4
into
google-ai-edge:main
6 of 7 checks passed
Contributor
|
Thank you! |
Contributor
Author
|
My second contribution to open source! The first one is for onnxruntime! |
Contributor
|
Haha, I made a lot of changes to onnxruntime as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… such as armv7-a in 32 bits)
Fix type mismatch in std::max for size_t Rank
The current code uses:
std::max(1lu, Rank)
This can cause template deduction issues because:
These types are not guaranteed to match across platforms, which may lead to compilation errors.
This change replaces it with:
std::max(static_cast<size_t>(1), Rank)
This ensures both arguments have the same type and makes
the code portable across platforms.
No functional change intended.
More specifically, I got an error of type mismatch when build for armv7-a and I got it work with
std::max(1u, Rank),
but then it will have problem with armv8. ChatGPT suggested static_cast to size_t.