Fix progress_utils_test.py to restrict mocking of system-wide modules to the module under test.#465
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_893984286
branch
3 times, most recently
from
2760319 to
3e66f1b
Compare
…es to the module under test. This test was failing because sometimes other modules were calling `time.time` or `tracemalloc.get_traced_memory`, stealing the mocked return value. Also add a warning that running with `tracemalloc` can significantly slow down the code. PiperOrigin-RevId: 895884076
copybara-service
Bot
force-pushed
the
test_893984286
branch
from
3e66f1b to
38864d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
progress_utils_test.pyto restrict mocking of system-wide modules to the module under test.This test was failing because sometimes other modules were calling
time.timeortracemalloc.get_traced_memory, stealing the mocked return value.Also add a warning that running with
tracemalloccan significantly slow down the code.