Fix templateIndices serialization crash for empty query_to_template_map#692
Closed
mooreneural wants to merge 1 commit into
Closed
Fix templateIndices serialization crash for empty query_to_template_map#692mooreneural wants to merge 1 commit into
mooreneural wants to merge 1 commit into
Conversation
When query_to_template_map is empty, `list(values) or None` serializes templateIndices as null. On deserialization, from_dict calls zip(queryIndices, None) which raises TypeError: 'NoneType' is not iterable. Fix: remove `or None` so an empty map serializes as [], consistent with how queryIndices is already written.
Augustin-Zidek
added a commit
that referenced
this pull request
Jul 9, 2026
From #692. PiperOrigin-RevId: 945022442 Change-Id: Idbebdf27f9eb16a8231b6fa128717a92a0d09964
Collaborator
|
Fixed in 62136ec. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a ProteinChain template has an empty query_to_template_map,
list(values) or Noneserializes templateIndices as null. Ondeserialization, from_dict calls zip(queryIndices, None) which raises:
Fix: remove
or Noneso an empty map serializes as [], consistent withhow queryIndices is already written on the line above.
Files changed