Skip to content

feat(GreensOpenProblems): 39#3804

Merged
mo271 merged 2 commits intogoogle-deepmind:mainfrom
jeangud:green-39
May 3, 2026
Merged

feat(GreensOpenProblems): 39#3804
mo271 merged 2 commits intogoogle-deepmind:mainfrom
jeangud:green-39

Conversation

@jeangud
Copy link
Copy Markdown
Contributor

@jeangud jeangud commented Apr 20, 2026

Description

If $A \subset \mathbb{Z}/p\mathbb{Z}$ is random, $|A| = \sqrt{p}$, can we almost surely cover $\mathbb{Z}/p\mathbb{Z}$ with $100\sqrt{p}$ translates of $A$?

  • Closes Green's Open Problems #39 #1595
  • 🤖 First draft created with help from Gemini 3.1 Pro. I then modified it to handle edge cases, improved code modularity, added variants, and simple tests. I then asked Gemini to come up with non-trivial tests by enumeration.
  • Formulation handles the 3 problem variants mentioned in Green's original comments.

Testing

✅ Builds successfully

$ lake build FormalConjectures/GreensOpenProblems/39.lean 
Build completed successfully (7982 jobs).

@github-actions github-actions Bot added the green-problems Problems from https://people.maths.ox.ac.uk/greenbj/papers/open-problems.pdf label Apr 20, 2026
Copy link
Copy Markdown
Collaborator

@mo271 mo271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks mathematically correct to me, just some nits

Comment thread FormalConjectures/GreensOpenProblems/39.lean Outdated
Comment thread FormalConjectures/GreensOpenProblems/39.lean Outdated
Comment thread FormalConjectures/GreensOpenProblems/39.lean Outdated
@jeangud
Copy link
Copy Markdown
Contributor Author

jeangud commented May 3, 2026

@mo271 thank you for the comments: addressed! ✅

I am hesitant to ask 🫣 but if you can spare the time, #2274 should also be ready for another look (despite the awaiting-author). No rush at all!

@mo271 mo271 merged commit 3ad2f28 into google-deepmind:main May 3, 2026
6 checks passed
@mo271
Copy link
Copy Markdown
Collaborator

mo271 commented May 3, 2026

@mo271 thank you for the comments: addressed! ✅

I am hesitant to ask 🫣 but if you can spare the time, #2274 should also be ready for another look (despite the awaiting-author). No rush at all!

Thanks again!

Btw: you can remove the awaiting-author label by commenting

-awaiting-author

on a pr. We should document this better...

@jeangud
Copy link
Copy Markdown
Contributor Author

jeangud commented May 4, 2026

@mo271 thank you for the comments: addressed! ✅
I am hesitant to ask 🫣 but if you can spare the time, #2274 should also be ready for another look (despite the awaiting-author). No rush at all!

Thanks again!

Btw: you can remove the awaiting-author label by commenting

-awaiting-author

on a pr. We should document this better...

🤯 Thank you for the pointer! Proposing #3934 if useful, please discard/close if not needed.

@github-actions github-actions Bot added the awaiting-author The author should answer a question or perform changes. Reply when done. label May 4, 2026
mo271 pushed a commit that referenced this pull request May 4, 2026
# Description
Motivated by [this
comment](#3804 (comment)),
adding a bit documentation on our custom label creation (without
elevated rights on the repo).

# Testing
No-op change.
mo271 pushed a commit that referenced this pull request May 4, 2026
# Description
Motivated by [this
comment](#3804 (comment)),
we would like to harmonize the AMS tags in the repo and disallow leading
zeros:
- Raise linting warning if the AMS tag contains leading zeros
- Fix 17 existing files not following the new convention

# Testing
:white_check_mark: Built the whole repo successfully without linting
warnings
```shell
$ lake build
Build completed successfully (8669 jobs).
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author The author should answer a question or perform changes. Reply when done. green-problems Problems from https://people.maths.ox.ac.uk/greenbj/papers/open-problems.pdf

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Green's Open Problems #39

2 participants