Skip to content

Add giscus-based comments and reactions#4292

Merged
mo271 merged 11 commits into
google-deepmind:mainfrom
codrut3:discussions-webtest
Jun 26, 2026
Merged

Add giscus-based comments and reactions#4292
mo271 merged 11 commits into
google-deepmind:mainfrom
codrut3:discussions-webtest

Conversation

@codrut3

@codrut3 codrut3 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Add comment, votes and predictions features, based on giscus.

codrut3 added 9 commits May 28, 2026 23:15
@github-actions

Copy link
Copy Markdown

👋 This is an automated welcome message. 🤖
Thanks for the contributions!

A few friendly reminders while the review gets started:

  • Please take a look at the style guidelines,
    especially the conventions for references, categories, AMS tags, and answer(sorry).
  • You can manage some PR labels by leaving a comment with +label-name or -label-name; for example, +awaiting-author or -awaiting-author.
  • This repository is mainly for formalised statements. Proofs longer than about 25-50 lines are usually out of scope; longer proofs are welcome to be included/linked via the formal_proof mechanism.

Thanks again for helping improve Formal Conjectures.

@mo271 mo271 requested a review from Paul-Lez June 19, 2026 19:37
@mo271

mo271 commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

@zond can you have a look, since this is based on your original pr..

@mo271 mo271 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great, thanks!

Perhaps we could add a documention/help page somewhere explaining the voting?!

EDIT

Especially so that users understand that votes are public and that a vote/comment is associated with their github user name

@zond

zond commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Ah, sorry, completely missed this!

@zond

zond commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Ah, sorry, completely missed this!

But it seems to have fairly little in common with my old PR :D

@mo271 mo271 added the website label Jun 23, 2026

@Paul-Lez Paul-Lez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One small question: is there a way to prevent users from voting simultaneously for "this conjecture is true" and for "this conjecture is false"?

@codrut3

codrut3 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

That looks great, thanks!

Perhaps we could add a documention/help page somewhere explaining the voting?!

Thank you for the suggestion, I added information in the About page, and linked to it from the theorem page.

@codrut3

codrut3 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Looks good! One small question: is there a way to prevent users from voting simultaneously for "this conjecture is true" and for "this conjecture is false"?

I can probably hide the opposite emoji as long as the user stays in the tab, but if they reload the tab I'll lose the context. Should I look into this? @mo271

@mo271

mo271 commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Looks good! One small question: is there a way to prevent users from voting simultaneously for "this conjecture is true" and for "this conjecture is false"?

I can probably hide the opposite emoji as long as the user stays in the tab, but if they reload the tab I'll lose the context. Should I look into this? @mo271

I think it is fine letting users upvote both True and False: perhaps we could even explain that this might correspond to "I think this question is not decidable/independent of ZFC" or something like that.
We can also do it in a follow up if we see that users are using it in this way

@mo271 mo271 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, LTGM!

@mo271 mo271 enabled auto-merge (squash) June 26, 2026 06:41
@mo271 mo271 merged commit c5f086c into google-deepmind:main Jun 26, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants