Skip to content

feat(GreensOpenProblems): 52#4305

Merged
mo271 merged 2 commits into
google-deepmind:mainfrom
jeangud:green-52
Jun 25, 2026
Merged

feat(GreensOpenProblems): 52#4305
mo271 merged 2 commits into
google-deepmind:mainfrom
jeangud:green-52

Conversation

@jeangud

@jeangud jeangud commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Description

Suppose that $A \subset \mathbb{F}_2^n$ is a set with an additive complement of size $K$ (that is, for which there is another set $S \subset \mathbb{F}_2^n$, $|S| = K$, with $A + S = \mathbb{F}_2^n$). Does $2A$ contain a coset of codimension $O_K(1)$? Could it even contain a coset of codimension $O(\log K)$? [Gr24]

  • Closes Green's Open Problems #52 #1657
  • Update: I had initially implemented this with the maxCosetDim helper from Green 51 but it complicated everything
  • 🤖 Initial draft obtained with Gemini 3.1 Pro and refined manually for style and correctness.
  • Variants left as a later exercise to keep this PR short

Testing

✅ Files build successfully

$ lake build FormalConjectures/GreensOpenProblems/52.lean
Build completed successfully (8035 jobs).

@github-actions

Copy link
Copy Markdown

👋 This is an automated welcome message. 🤖
Thanks for the contributions!

A few friendly reminders while the review gets started:

  • Please take a look at the style guidelines,
    especially the conventions for references, categories, AMS tags, and answer(sorry).
  • You can manage some PR labels by leaving a comment with +label-name or -label-name; for example, +awaiting-author or -awaiting-author.
  • This repository is mainly for formalised statements. Proofs longer than about 25-50 lines are usually out of scope; longer proofs are welcome to be included/linked via the formal_proof mechanism.

Thanks again for helping improve Formal Conjectures.

@github-actions github-actions Bot added the green-problems Problems from https://people.maths.ox.ac.uk/greenbj/papers/open-problems.pdf label Jun 23, 2026
@jeangud

jeangud commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

Actually converting back to draft, I want to see if we can make do without the maxCosetDim from Green 51.

@jeangud jeangud marked this pull request as draft June 23, 2026 14:53
@jeangud

jeangud commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

Simplified the implementation, now ready for review. Sorry about the double-post 😬

@jeangud jeangud marked this pull request as ready for review June 24, 2026 02:54

@mo271 mo271 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM modulo one minor comment, that could also be addressed in a follow up

Comment thread FormalConjectures/GreensOpenProblems/52.lean Outdated
@mo271 mo271 added the awaiting-author The author should answer a question or perform changes. Reply when done. label Jun 24, 2026
mo271 pushed a commit that referenced this pull request Jun 24, 2026
# Description
This PR proposes to introduce a notation shorthand for 𝔽-p groups, which
is already used (and redefined each time) in files over the repo.

**Note:** to be merged before #4305 and #4309

# Testing
:white_check_mark: Built the whole repo successfully
```shell
$ lake --wfail build
Build completed successfully (8814 jobs).
```
@jeangud jeangud removed the awaiting-author The author should answer a question or perform changes. Reply when done. label Jun 25, 2026
@mo271 mo271 merged commit ef4efd5 into google-deepmind:main Jun 25, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

green-problems Problems from https://people.maths.ox.ac.uk/greenbj/papers/open-problems.pdf

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Green's Open Problems #52

2 participants