feat(GreensOpenProblems): 52#4305
Merged
Merged
Conversation
|
👋 This is an automated welcome message. 🤖 A few friendly reminders while the review gets started:
Thanks again for helping improve Formal Conjectures. |
Collaborator
Author
|
Actually converting back to draft, I want to see if we can make do without the |
Collaborator
Author
|
Simplified the implementation, now ready for review. Sorry about the double-post 😬 |
mo271
approved these changes
Jun 24, 2026
mo271
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, LGTM modulo one minor comment, that could also be addressed in a follow up
mo271
pushed a commit
that referenced
this pull request
Jun 24, 2026
# Description This PR proposes to introduce a notation shorthand for 𝔽-p groups, which is already used (and redefined each time) in files over the repo. **Note:** to be merged before #4305 and #4309 # Testing :white_check_mark: Built the whole repo successfully ```shell $ lake --wfail build Build completed successfully (8814 jobs). ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
maxCosetDimhelper from Green 51 but it complicated everythingTesting
✅ Files build successfully