Skip to content

Fix incorrect parameter descriptions in model_utils.py #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chessing234 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix incorrect parameter descriptions in model_utils.py #210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions graphcast/model_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def get_graph_spatial_features(
longitude from relative features, unless
`relative_longitude_local_coordinates` is also True, or if there is any
bias on the relative edge sizes for different longitudes.
add_relative_positions: Whether to relative positions in R3 to the edges.
add_relative_positions: Whether to add relative positions in R3 to the edges.
edge_normalization_factor: Allows explicitly controlling edge normalization.
If None, defaults to max edge length. This supports using pre-trained
model weights with a different graph structure to what it was trained.
Expand Down Expand Up @@ -254,9 +254,9 @@ def get_relative_position_in_receiver_local_coordinates(
node_theta: [num_nodes] with azimuthal angles.
senders: [num_edges] with indices.
receivers: [num_edges] with indices.
latitude_local_coordinates: Whether to rotate edges such that in the
latitude_local_coordinates: Whether to rotate edges such that the
positions are computed such that the receiver is always at latitude 0.
longitude_local_coordinates: Whether to rotate edges such that in the
longitude_local_coordinates: Whether to rotate edges such that the
positions are computed such that the receiver is always at longitude 0.
np_: Numpy library interface.
transform_: scipy.transform library interface.
Expand Down Expand Up @@ -447,7 +447,7 @@ def get_bipartite_graph_spatial_features(
from relative features, unless `relative_longitude_local_coordinates` is
also True, or if there is any bias on the relative edge sizes for
different longitudes.
add_relative_positions: Whether to relative positions in R3 to the edges.
add_relative_positions: Whether to add relative positions in R3 to the edges.
edge_normalization_factor: Allows explicitly controlling edge normalization.
If None, defaults to max edge length. This supports using pre-trained
model weights with a different graph structure to what it was trained on.
Expand Down Expand Up @@ -569,12 +569,12 @@ def get_bipartite_relative_position_in_receiver_local_coordinates(
senders_node_phi: [num_sender_nodes] with polar angles.
senders_node_theta: [num_sender_nodes] with azimuthal angles.
senders: [num_edges] with indices into sender nodes.
receivers_node_phi: [num_sender_nodes] with polar angles.
receivers_node_theta: [num_sender_nodes] with azimuthal angles.
receivers_node_phi: [num_receiver_nodes] with polar angles.
receivers_node_theta: [num_receiver_nodes] with azimuthal angles.
receivers: [num_edges] with indices into receiver nodes.
latitude_local_coordinates: Whether to rotate edges such that in the
latitude_local_coordinates: Whether to rotate edges such that the
positions are computed such that the receiver is always at latitude 0.
longitude_local_coordinates: Whether to rotate edges such that in the
longitude_local_coordinates: Whether to rotate edges such that the
positions are computed such that the receiver is always at longitude 0.
np_: Numpy library interface.
transform_: scipy.transform library interface.
Expand Down