Defer texture destruction in ImguiBridge to prevent use-after-free.

yuvaltassa · copybara-github · commit 2cacf170710e · 2026-06-20T09:46:52.000-07:00
PiperOrigin-RevId: 935327326
Change-Id: I12a148b71abbe50581c7977a1f6dc5e220c40e81
diff --git a/src/experimental/platform/ux/imgui_bridge.cc b/src/experimental/platform/ux/imgui_bridge.cc
@@ -203,7 +203,7 @@ void ImguiBridge::Update() {
       } else if (tex->Status == ImTextureStatus_WantUpdates) {
         UpdateTexture(tex);
       } else if (tex->Status == ImTextureStatus_WantDestroy &&
-                 tex->UnusedFrames > 0) {
+                 tex->UnusedFrames >= 3) {
         DestroyTexture(tex);
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -203,7 +203,7 @@ void ImguiBridge::Update() {`
`203`	`203`	`} else if (tex->Status == ImTextureStatus_WantUpdates) {`
`204`	`204`	`UpdateTexture(tex);`
`205`	`205`	`} else if (tex->Status == ImTextureStatus_WantDestroy &&`
`206`		`- tex->UnusedFrames > 0) {`
	`206`	`+ tex->UnusedFrames >= 3) {`
`207`	`207`	`DestroyTexture(tex);`
`208`	`208`	`}`
`209`	`209`	`}`