Neural Equilibrium Solvers for OpenSpiel#1526
Open
alexunderch wants to merge 14 commits into
Open
Conversation
lanctot
requested changes
Apr 30, 2026
lanctot
left a comment
Collaborator
There was a problem hiding this comment.
Can you add NES to docs/algorithms.md?
Collaborator
|
Thanks! |
lukemarris
reviewed
Apr 30, 2026
lukemarris
left a comment
Member
There was a problem hiding this comment.
First pass through.
I would focus on:
- Just CCE
- Just ME
- Fixed shape game (say 4x4) No masking
When that is working well we can add the other bells and whistles.
lanctot
requested changes
Jul 8, 2026
lanctot
left a comment
Collaborator
There was a problem hiding this comment.
Changes look good on my side but would still like Luke's final OK before we import. Let's continue this when he's back
lanctot
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to introduce the concept of Neural equilibrium solvers, following the papers:
So far, we've got [Ready for the review]:
In the draft stage:
This pull request in created maybe too early to facilitate the development process (Dr. Marris may or may not be somewhat shy). I think that it does not currently learn correctly (from the fundamental perspective) and lacks some utility (see README).
CC to @lanctot : for a while, don't run the CI/CD: it takes some time and I haven't put the tests to the Makefile, until we fix we ensure that I match that "internal" implementation in necessary capacity. Thank you.
@lukemarris, your turn.
P.s. I understand that I did use AI to fulfill some code snippets in question. However, whole code was read and run by me, and I'll eliminate these parts in the future: I had no1 to ask questions, sorry.