Issue #1658 - Add SSBroyden and SSBFGS optimizers to optax.contrib #1659
Open
armbrusl wants to merge 3 commits intogoogle-deepmind:mainfrom
Open
Issue #1658 - Add SSBroyden and SSBFGS optimizers to optax.contrib #1659armbrusl wants to merge 3 commits intogoogle-deepmind:mainfrom
armbrusl wants to merge 3 commits intogoogle-deepmind:mainfrom
Conversation
Port the Self-Scaled Broyden and Self-Scaled BFGS quasi-Newton optimizers from PyTorch (SciMBA) to JAX/optax. These maintain a dense inverse Hessian approximation with self-scaling updates, complementing the existing L-BFGS implementation for small to medium scale problems. New public API: - optax.contrib.ssbroyden() — SS-Broyden variant - optax.contrib.ssbfgs() — SS-BFGS variant - optax.contrib.scale_by_ss_quasi_newton() — shared core transform Both integrate with scale_by_zoom_linesearch (same pattern as optax.lbfgs) and include tests on quadratic and Rosenbrock functions. Reference: Urbán et al. (2025), Journal of Computational Physics, 523, 113656.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I have added the CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the Self-Scaled Broyden and Self-Scaled BFGS quasi-Newton optimizers from PyTorch (SciMBA) to JAX/optax. These maintain a dense inverse Hessian approximation with self-scaling updates, complementing the existing L-BFGS implementation for small to medium scale problems.
New public API:
Both integrate with scale_by_zoom_linesearch (same pattern as optax.lbfgs) and include tests on quadratic and Rosenbrock functions.
Reference: Urbán et al. (2025), Journal of Computational Physics, 523, 113656.