Skip to content

Update IMAS DD version to 4.1.1#2130

Open
MateoBell wants to merge 1 commit intomainfrom
update_imas_data_dictionary_version_4.1
Open

Update IMAS DD version to 4.1.1#2130
MateoBell wants to merge 1 commit intomainfrom
update_imas_data_dictionary_version_4.1

Conversation

@MateoBell
Copy link
Copy Markdown
Collaborator

Upgrade IMAS DD version from 4.0.0 to 4.1.1 and renames changed fields. This remove the need for the try:.. except when mapping from/to plasma_profiles IDSs.
Also adds more metadata to the output IDSs

Also adds more metadata to the output IDSs
@MateoBell MateoBell added the ready for review Add to PRs when they are ready for review unsure of who to assign as reviewer label Apr 22, 2026
@Nush395
Copy link
Copy Markdown
Collaborator

Nush395 commented Apr 22, 2026

Does DD version 4.1.1 match to a specific version of imas python?

@MateoBell
Copy link
Copy Markdown
Collaborator Author

No I think both are compatible with imas-python 2.1 or newer. It just needs specific version of this repo: https://github.com/iterorganization/IMAS-Data-Dictionaries, which is a dependency of imas-python.

@Nush395
Copy link
Copy Markdown
Collaborator

Nush395 commented Apr 22, 2026

No I think both are compatible with imas-python 2.1 or newer. It just needs specific version of this repo: https://github.com/iterorganization/IMAS-Data-Dictionaries, which is a dependency of imas-python.

I see, so how would we verify that a TORAX user is using DD 4.1.1 ?

@MateoBell
Copy link
Copy Markdown
Collaborator Author

MateoBell commented Apr 22, 2026

Ah good point. I think we cannot know for sure. If it installs the dependencies it will automatically have 4.1.1 as default version and convert IDS to this version if needed (default in the loader.py function).
But for core_profiles or equilibrium inputs for example if it's 4/0 or 4.1.1 it would work in both cases as the IDS structures did not change (at least the field TORAX uses). And if it fails it is because a field has been renamed, but the conventions are the same between the two versions.
Do you want TORAX to fail explicitly if the IDSs are not in the good version ?

@MateoBell
Copy link
Copy Markdown
Collaborator Author

Also, we could add imas-data-dictionaries to TORAX dependencies to ensure the latest DD version (or specifically 4.1.1) is installed for TORAX users ?

@Nush395
Copy link
Copy Markdown
Collaborator

Nush395 commented May 6, 2026

Also, we could add imas-data-dictionaries to TORAX dependencies to ensure the latest DD version (or specifically 4.1.1) is installed for TORAX users ?

That feels like a good solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Add to PRs when they are ready for review unsure of who to assign as reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants