Security: Input validation relies on assert, which can be disabled#2132
Open
tomaioo wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Security: Input validation relies on assert, which can be disabled#2132tomaioo wants to merge 1 commit intogoogle-deepmind:mainfrom
assert, which can be disabled#2132tomaioo wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
Validation of `JAX_PRECISION` uses `assert`. Python `assert` statements are removed when running with optimization flags (`-O`), which can bypass this check and allow unexpected values to propagate. While not directly exploitable on its own, this weakens defensive validation. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Input validation relies on
assert, which can be disabledProblem
Severity:
Low| File:torax/__init__.py:L84Validation of
JAX_PRECISIONusesassert. Pythonassertstatements are removed when running with optimization flags (-O), which can bypass this check and allow unexpected values to propagate. While not directly exploitable on its own, this weakens defensive validation.Solution
Replace
assertwith explicit runtime checks, e.g.,if precision not in {'f32','f64'}: raise ValueError(...).Changes
torax/__init__.py(modified)