Update to make more idiomatic#23
Open
rbranham wants to merge 1 commit intogoogle-developer-training:masterfrom
Open
Update to make more idiomatic#23rbranham wants to merge 1 commit intogoogle-developer-training:masterfrom
rbranham wants to merge 1 commit intogoogle-developer-training:masterfrom
Conversation
Since there is an emphasis on writing concise code, I think it would be a good idea to have the when expression directly be an argument. It will save a variable definition and is more in line with Kotlin style. Code lab documents probably need to be updated as well but could not find if they were open source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since there is an emphasis on writing concise code, I think it would be a good idea to have the when expression directly be an argument. It will save a variable definition and is more in line with the Kotlin style. Code lab documents probably need to be updated as well but could not find if they were open source to suggest an update.